Bug: Allow points where canvas-y === 0
authorJoseph Rossi <jrossi@optirtc.com>
Mon, 16 Nov 2015 19:06:46 +0000 (14:06 -0500)
committerJoseph Rossi <jrossi@optirtc.com>
Mon, 16 Nov 2015 20:49:29 +0000 (15:49 -0500)
The check for `utils.isOK` blacklists the value 0. In the context of
validating selected points and reporting them in the legend, any point
where canvas-y zero should be included.

src/dygraph.js
src/plugins/legend.js

index bc75fef..a5e326d 100644 (file)
@@ -1815,7 +1815,7 @@ Dygraph.prototype.updateSelection_ = function(opt_animFraction) {
     ctx.save();
     for (i = 0; i < this.selPoints_.length; i++) {
       var pt = this.selPoints_[i];
-      if (!utils.isOK(pt.canvasy)) continue;
+      if (isNaN(pt.canvasy) || pt.canvasy === null) continue;
 
       var circleSize = this.getNumericOption('highlightCircleSize', pt.name);
       var callback = this.getFunctionOption("drawHighlightPointCallback", pt.name);
index c0ab35a..ab22fbb 100644 (file)
@@ -268,7 +268,7 @@ Legend.generateLegendHTML = function(g, x, sel_points, oneEmWidth, row) {
       var seriesData = labelToSeries[pt.name];
       seriesData.y = pt.yval;
 
-      if ((pt.yval === 0 && !showZeros) || !utils.isOK(pt.canvasy)) {
+      if ((pt.yval === 0 && !showZeros) || isNaN(pt.canvasy) || pt.canvasy === null) {
         seriesData.isVisible = false;
         continue;
       }