PR Comment: Adding check for undefined and changing back file modes

diff --git a/auto_tests/tests/highlight_series_background.js b/auto_tests/tests/highlight_series_background.js
old mode 100755 (executable)
new mode 100644 (file)

diff --git a/auto_tests/tests/plugins_legend.js b/auto_tests/tests/plugins_legend.js
old mode 100755 (executable)
new mode 100644 (file)

diff --git a/src/dygraph.js b/src/dygraph.js
index a5e326d..ee39383 100644 (file)
--- a/src/dygraph.js
+++ b/src/dygraph.js
@@ -1815,7 +1815,7 @@ Dygraph.prototype.updateSelection_ = function(opt_animFraction) {
     ctx.save();
     for (i = 0; i < this.selPoints_.length; i++) {
       var pt = this.selPoints_[i];
-      if (isNaN(pt.canvasy) || pt.canvasy === null) continue;
+      if (isNaN(pt.canvasy) || pt.canvasy === null || pt.canvasy === undefined) continue;
 
       var circleSize = this.getNumericOption('highlightCircleSize', pt.name);
       var callback = this.getFunctionOption("drawHighlightPointCallback", pt.name);

diff --git a/src/plugins/legend.js b/src/plugins/legend.js
index ab22fbb..9644576 100644 (file)
--- a/src/plugins/legend.js
+++ b/src/plugins/legend.js
@@ -268,7 +268,7 @@ Legend.generateLegendHTML = function(g, x, sel_points, oneEmWidth, row) {
       var seriesData = labelToSeries[pt.name];
       seriesData.y = pt.yval;
 
-      if ((pt.yval === 0 && !showZeros) || isNaN(pt.canvasy) || pt.canvasy === null) {
+      if ((pt.yval === 0 && !showZeros) || isNaN(pt.canvasy) || pt.canvasy === null || pt.canvasy === undefined) {
         seriesData.isVisible = false;
         continue;
       }