From aec24511f59ace8681d28cb5d11d04f9f57357b4 Mon Sep 17 00:00:00 2001 From: Dan Vanderkam Date: Sat, 1 Oct 2016 16:25:44 -0400 Subject: [PATCH] Remove isAndroid checks (#784) --- src/dygraph-canvas.js | 22 +++++++++------------- src/dygraph-utils.js | 11 ----------- 2 files changed, 9 insertions(+), 24 deletions(-) diff --git a/src/dygraph-canvas.js b/src/dygraph-canvas.js index bd37e67..7377239 100644 --- a/src/dygraph-canvas.js +++ b/src/dygraph-canvas.js @@ -68,19 +68,15 @@ var DygraphCanvasRenderer = function(dygraph, element, elementContext, layout) { // Set up a clipping area for the canvas (and the interaction canvas). // This ensures that we don't overdraw. - // on Android 3 and 4, setting a clipping area on a canvas prevents it from - // displaying anything. - if (!utils.isAndroid()) { - var ctx = this.dygraph_.canvas_ctx_; - ctx.beginPath(); - ctx.rect(this.area.x, this.area.y, this.area.w, this.area.h); - ctx.clip(); + var ctx = this.dygraph_.canvas_ctx_; + ctx.beginPath(); + ctx.rect(this.area.x, this.area.y, this.area.w, this.area.h); + ctx.clip(); - ctx = this.dygraph_.hidden_ctx_; - ctx.beginPath(); - ctx.rect(this.area.x, this.area.y, this.area.w, this.area.h); - ctx.clip(); - } + ctx = this.dygraph_.hidden_ctx_; + ctx.beginPath(); + ctx.rect(this.area.x, this.area.y, this.area.w, this.area.h); + ctx.clip(); }; /** @@ -544,7 +540,7 @@ DygraphCanvasRenderer._errorPlotter = function(e) { * Proxy for CanvasRenderingContext2D which drops moveTo/lineTo calls which are * superfluous. It accumulates all movements which haven't changed the x-value * and only applies the two with the most extreme y-values. - * + * * Calls to lineTo/moveTo must have non-decreasing x-values. */ DygraphCanvasRenderer._fastCanvasProxy = function(context) { diff --git a/src/dygraph-utils.js b/src/dygraph-utils.js index 8e972a6..c319e49 100644 --- a/src/dygraph-utils.js +++ b/src/dygraph-utils.js @@ -686,17 +686,6 @@ export function getContextPixelRatio(context) { }; /** - * Checks whether the user is on an Android browser. - * Android does not fully support the tag, e.g. w/r/t/ clipping. - * @return {boolean} - * @private - */ -export function isAndroid() { - return (/Android/).test(navigator.userAgent); -}; - - -/** * TODO(danvk): use @template here when it's better supported for classes. * @param {!Array} array * @param {number} start -- 2.7.4