From fb2b89c8d082b2bd83b5e809d343254e388adb4c Mon Sep 17 00:00:00 2001 From: Myles Bostwick Date: Thu, 22 Jan 2015 14:38:34 -0700 Subject: [PATCH] Add cleanup function to the animation selection so that clearing a selection always happens. --- dygraph.js | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/dygraph.js b/dygraph.js index 5f6e1e1..4502bd4 100644 --- a/dygraph.js +++ b/dygraph.js @@ -2019,6 +2019,14 @@ Dygraph.prototype.animateSelection_ = function(direction) { var thisId = ++this.animateId; var that = this; + var cleanupIfClearing = function() { + // if we haven't reached fadeLevel 0 in the max frame time, + // ensure that the clear happens and just go to 0 + if (that.fadeLevel !== 0 && direction < 0) { + that.fadeLevel = 0; + that.clearSelection(); + } + }; Dygraph.repeatAndCleanup( function(n) { // ignore simultaneous animations @@ -2031,7 +2039,7 @@ Dygraph.prototype.animateSelection_ = function(direction) { that.updateSelection_(that.fadeLevel / totalSteps); } }, - steps, millis, function() {}); + steps, millis, cleanupIfClearing); }; /** -- 2.7.4