Klaus Weidner [Sun, 10 Feb 2013 23:10:06 +0000 (15:10 -0800)]
Address code review comments
Klaus Weidner [Sat, 9 Feb 2013 01:01:10 +0000 (17:01 -0800)]
Add new options xRangePad and yRangePad
These options provide a fixed margin (in pixels) around the
user-specified or autoselected axis range to ensure all data points are
fully visible. If these are not set by the user, behavior reverts to
backward compatible mode.
This helps avoid the issue of data points drawn at the graph edges not
being properly visible. For example, in a 100-pixel high plot area, a Y
coordinate of zero on a graph with yrange [0, ...] will be scaled to
domY=100 which is outside the 0..99 visible area.
If I'm understanding it right, the original padding algorithm works
as follows:
Add 10% padding for automatic Y ranges, but not for user-supplied
ranges, and move a close-to-zero edge to zero except if avoidMinZero
is set. If logscale is set, add a variable amount of padding at the
top but none at the bottom.
This is not very intuitive, and lines drawn at the edge of a
user-supplied range will still be invisible.
The new algorithm consistently ensures that there are at least
{x,y}RangePad pixels available for drawing outside of the data range,
both for user-specified and autoselected ranges.
Setting a small xRangePad combines nicely with drawAxesAtZero,
it will provide tick marks next to the legend due to the grid extending
slightly past the axis.
See the included gallery demo 'Edge Padding'. The default setting
corresponds to legacy behavior. Recommended settings:
includeZero: true,
drawAxesAtZero: true,
xRangePad: 4,
yRangePad: 10
Robert Konigsberg [Thu, 7 Feb 2013 14:25:11 +0000 (09:25 -0500)]
Namespace the canvas proxy in auto tests.
Robert Konigsberg [Sat, 2 Feb 2013 22:00:16 +0000 (14:00 -0800)]
Merge pull request #207 from kberg/master
Fix RGBColor -> RGBColorParser rename in tests/
Robert Konigsberg [Sat, 2 Feb 2013 21:55:02 +0000 (13:55 -0800)]
s/RGBColor/RGBColorParser in the tests directory.
Robert Konigsberg [Sat, 2 Feb 2013 17:24:38 +0000 (09:24 -0800)]
Merge pull request #206 from kberg/master
Write test that verifies that resizing a graph maintains highlightCallback.
Robert Konigsberg [Sat, 2 Feb 2013 17:21:37 +0000 (09:21 -0800)]
Add new test to verify that highlightCallback still works after graph resize.
Dan Vanderkam [Fri, 1 Feb 2013 17:21:51 +0000 (09:21 -0800)]
Merge pull request #199 from witsa/master
some robustness and partial auto value range
Dan Vanderkam [Fri, 1 Feb 2013 16:53:34 +0000 (11:53 -0500)]
Fix "Unnecessary semicolon" lint error
manufitoussi [Fri, 1 Feb 2013 10:17:38 +0000 (11:17 +0100)]
Changing name of isUnspecifiedLimit function to isNullUndefinedOrNaN
Dan Vanderkam [Thu, 31 Jan 2013 15:52:38 +0000 (07:52 -0800)]
Merge pull request #203 from witsa/resize_handler
Resize handler
Dan Vanderkam [Thu, 31 Jan 2013 15:46:56 +0000 (07:46 -0800)]
Merge pull request #205 from kberg/docs
Update docs for committing changes.
Robert Konigsberg [Thu, 31 Jan 2013 14:37:40 +0000 (06:37 -0800)]
Update docs for committing changes.
manufitoussi [Wed, 30 Jan 2013 13:54:40 +0000 (14:54 +0100)]
remove wrong argument of parseFloat
manufitoussi [Wed, 30 Jan 2013 09:58:45 +0000 (10:58 +0100)]
Resize event causes several mouseUp handler to be be added. Prevent multiple registration.
manufitoussi [Wed, 30 Jan 2013 09:57:21 +0000 (10:57 +0100)]
fix an resize issue : when the window has resized, mouseout and mousemove handlers are no longer registered.
Emmanuel Fitoussi [Wed, 30 Jan 2013 09:51:31 +0000 (01:51 -0800)]
Merge pull request #4 from danvk/master
Get last version
manufitoussi [Wed, 30 Jan 2013 08:25:46 +0000 (09:25 +0100)]
refactoring of detection of unspecified limit.
manufitoussi [Wed, 30 Jan 2013 08:22:50 +0000 (09:22 +0100)]
reference sentence rewrite
Emmanuel Fitoussi [Wed, 30 Jan 2013 08:07:40 +0000 (00:07 -0800)]
Merge pull request #3 from danvk/master
Get last version
Dan Vanderkam [Tue, 29 Jan 2013 23:51:04 +0000 (18:51 -0500)]
add broken test demo to show margin issues
Dan Vanderkam [Tue, 29 Jan 2013 21:26:17 +0000 (13:26 -0800)]
Merge pull request #202 from kberg/tweak-tests
Only print PASS when failed test count == 0. Or is that === 0?
Dan Vanderkam [Tue, 29 Jan 2013 21:04:39 +0000 (13:04 -0800)]
Merge pull request #200 from kberg/resize-handler
Resize handler
Dan Vanderkam [Tue, 29 Jan 2013 21:02:02 +0000 (13:02 -0800)]
Merge pull request #201 from kberg/lint-cleanse
Fix lint warnings.
Robert Konigsberg [Tue, 29 Jan 2013 21:01:16 +0000 (16:01 -0500)]
Only print PASS when failed test count == 0. Or is that === 0?
Robert Konigsberg [Tue, 29 Jan 2013 20:58:34 +0000 (15:58 -0500)]
Fix lint warnings.
Dan Vanderkam [Tue, 29 Jan 2013 19:25:24 +0000 (14:25 -0500)]
add advice about delaying dygraph instantiation when using excanvas.
Dan Vanderkam [Fri, 25 Jan 2013 21:22:55 +0000 (16:22 -0500)]
use Dygraph.log in dygraphs.js
Emmanuel Fitoussi [Fri, 25 Jan 2013 21:05:24 +0000 (22:05 +0100)]
Revert "To avoid the rising count of useless resizes : we remove the handler if it exists before re-adding it."
This reverts commit
194075ffc1b1c44e37e785aed7dc92e777d7d192.
Robert Konigsberg [Fri, 25 Jan 2013 19:57:27 +0000 (14:57 -0500)]
Resize event causes several event handlers to be be added. Make the events private, and prevent multiple registration.
Robert Konigsberg [Fri, 25 Jan 2013 18:40:20 +0000 (13:40 -0500)]
resize handler only added once per graph.
manufitoussi [Fri, 25 Jan 2013 17:37:45 +0000 (18:37 +0100)]
update reference description about the partial auto range.
manufitoussi [Fri, 25 Jan 2013 17:31:44 +0000 (18:31 +0100)]
Partial auto y range : adding support of null and undefined in addition to NaN
manufitoussi [Fri, 25 Jan 2013 15:34:32 +0000 (16:34 +0100)]
Allows that user specifies only one limit of valueRange and let other one to be calculated automatically, by exemple [NaN,30].
Dan Vanderkam [Fri, 25 Jan 2013 14:38:46 +0000 (09:38 -0500)]
move plugins/unzoom.js -> extras/unzoom.js
Dan Vanderkam [Fri, 25 Jan 2013 14:37:52 +0000 (06:37 -0800)]
Merge pull request #198 from klausw-g/generate-refactor
refactor generate-combined.sh
manufitoussi [Fri, 25 Jan 2013 14:36:48 +0000 (15:36 +0100)]
Adding test for the per axis option includeZero
manufitoussi [Fri, 25 Jan 2013 13:25:46 +0000 (14:25 +0100)]
Adding an robustness test before using the registered events member.
manufitoussi [Fri, 25 Jan 2013 13:23:54 +0000 (14:23 +0100)]
To avoid the rising count of useless resizes : we remove the handler if it exists before re-adding it.
Klaus Weidner [Fri, 25 Jan 2013 00:53:13 +0000 (16:53 -0800)]
refactor generate-combined.sh
Update the generate-combined.sh script to support printing an ordered
source file list, cat'ing the compressed or uncompressed output, or
updating the dygraph-combined.js file (the default). This is intended to
make it easier to integrate dygraphs code into other builds.
Move the plugins/{base,install}.js files to
dygraph-plugin-{base,install}.js, this simplifies the file list
by permitting use of plugins/*.js with no order dependency.
Emmanuel Fitoussi [Thu, 24 Jan 2013 17:15:34 +0000 (09:15 -0800)]
Merge pull request #2 from witsa/master
Get last version
Emmanuel Fitoussi [Thu, 24 Jan 2013 17:13:29 +0000 (09:13 -0800)]
Merge pull request #1 from danvk/master
Get last version
Dan Vanderkam [Thu, 24 Jan 2013 03:48:58 +0000 (22:48 -0500)]
fix typo
Dan Vanderkam [Thu, 24 Jan 2013 03:29:48 +0000 (22:29 -0500)]
add note about http-equiv being first in the head section
Dan Vanderkam [Wed, 23 Jan 2013 21:49:02 +0000 (16:49 -0500)]
remove unused opt
Dan Vanderkam [Wed, 23 Jan 2013 03:12:44 +0000 (22:12 -0500)]
wrap DygraphOptions
Dan Vanderkam [Wed, 23 Jan 2013 03:09:50 +0000 (22:09 -0500)]
nearly all lint errors gone; closure compiler still happy
Dan Vanderkam [Tue, 22 Jan 2013 19:35:37 +0000 (14:35 -0500)]
lint checks mostly pass
Paul Felix [Thu, 6 Sep 2012 13:24:58 +0000 (09:24 -0400)]
Handling zoom handle left position as a floating-point number for better accuracy at the extremes.
Paul Felix [Thu, 10 Jan 2013 14:17:43 +0000 (09:17 -0500)]
More range selector auto tests
Paul Felix [Tue, 8 Jan 2013 18:24:48 +0000 (13:24 -0500)]
Changes based on comments from pull request
Paul Felix [Tue, 8 Jan 2013 18:24:08 +0000 (13:24 -0500)]
Need to call createDragInterface_() after plugins are activated in order to allow a plugin to change the default interactionModel.
Paul Felix [Tue, 8 Jan 2013 18:22:33 +0000 (13:22 -0500)]
Moved check for labels existence into reparseSeries since that method is also called by Dygraph.updateOptions()
Paul Felix [Mon, 7 Jan 2013 18:41:56 +0000 (13:41 -0500)]
Range selector is now a plugin
Conflicts:
dygraph-combined.js
Robert Konigsberg [Fri, 11 Jan 2013 15:12:00 +0000 (07:12 -0800)]
Merge pull request #194 from kberg/unzoom
Fix issue http://code.google.com/p/dygraphs/issues/detail?id=58 using plug-ins
Robert Konigsberg [Fri, 11 Jan 2013 15:11:05 +0000 (10:11 -0500)]
Last set of code review comments for unzoom.
Robert Konigsberg [Fri, 11 Jan 2013 03:52:56 +0000 (22:52 -0500)]
Code review comments.
Robert Konigsberg [Fri, 11 Jan 2013 02:24:18 +0000 (21:24 -0500)]
Merge branch 'master' into unzoom
Dan Vanderkam [Thu, 10 Jan 2013 21:59:42 +0000 (13:59 -0800)]
Merge pull request #197 from kberg/dounzoom
Move doUnzoom_ to the public API.
Robert Konigsberg [Wed, 9 Jan 2013 01:31:06 +0000 (20:31 -0500)]
Better name (thanks Paul.)
Robert Konigsberg [Wed, 9 Jan 2013 01:17:26 +0000 (20:17 -0500)]
Move doUnzoom_ to the public API.
Robert Konigsberg [Fri, 4 Jan 2013 19:45:20 +0000 (14:45 -0500)]
Took a while to get conditional show to work; works in the case where you zoom in on a graph using the mouse, and don't have the mouseover event since you're already over.
Robert Konigsberg [Fri, 4 Jan 2013 19:30:47 +0000 (14:30 -0500)]
Fix responsese to code review 194.
Dan Vanderkam [Fri, 4 Jan 2013 18:03:05 +0000 (10:03 -0800)]
Merge pull request #195 from kberg/415
Fix bug 415
Robert Konigsberg [Fri, 4 Jan 2013 04:05:42 +0000 (23:05 -0500)]
Fix bug 415. Series must be specicied by name in the options object.
Robert Konigsberg [Fri, 4 Jan 2013 03:39:40 +0000 (22:39 -0500)]
Merge branch 'master' of https://github.com/danvk/dygraphs
Conflicts:
auto_tests/tests/axis_labels.js
dygraph-options.js
plugins/axes.js
Robert Konigsberg [Fri, 4 Jan 2013 03:35:56 +0000 (22:35 -0500)]
Merge branch 'master' of github.com:kberg/dygraphs
Conflicts:
auto_tests/tests/axis_labels.js
Robert Konigsberg [Fri, 4 Jan 2013 02:59:30 +0000 (21:59 -0500)]
Add new test to misc/local.html
Robert Konigsberg [Fri, 4 Jan 2013 02:48:06 +0000 (21:48 -0500)]
Add plugins option to Dygraphs. Add demo-test. Add test.
Robert Konigsberg [Thu, 3 Jan 2013 23:21:40 +0000 (15:21 -0800)]
Merge pull request #193 from kberg/axis-label-font-size
Axis label font size
Robert Konigsberg [Thu, 3 Jan 2013 23:14:32 +0000 (18:14 -0500)]
Fix minor typo.
Robert Konigsberg [Thu, 3 Jan 2013 22:24:44 +0000 (17:24 -0500)]
Unzoom plug-in, rev 1.
Robert Konigsberg [Thu, 3 Jan 2013 20:29:20 +0000 (15:29 -0500)]
Merge branch 'master' of git://github.com/danvk/dygraphs into axis-label-font-size
Conflicts:
dygraph-options.js
Robert Konigsberg [Thu, 3 Jan 2013 20:27:27 +0000 (15:27 -0500)]
Comments froim review 193.
Robert Konigsberg [Thu, 3 Jan 2013 20:14:37 +0000 (15:14 -0500)]
s/String/string in jsdoc for dygraph-options.js.
Dan Vanderkam [Thu, 3 Jan 2013 19:01:30 +0000 (11:01 -0800)]
Merge pull request #192 from kberg/master
Options now includes default values. Fix bug so that you can set some options to null.
Robert Konigsberg [Tue, 1 Jan 2013 20:24:28 +0000 (15:24 -0500)]
Add warning that perhaps we do need an options API that gives non-default values.
Robert Konigsberg [Tue, 1 Jan 2013 20:04:13 +0000 (15:04 -0500)]
Add axisLineColor and axisLineWidth to the per-axis configurable options.
Robert Konigsberg [Mon, 31 Dec 2012 20:11:11 +0000 (15:11 -0500)]
Merge branch 'master' of github.com:kberg/dygraphs into axis-label-font-size
Conflicts:
auto_tests/tests/axis_labels.js
Robert Konigsberg [Mon, 31 Dec 2012 20:07:08 +0000 (15:07 -0500)]
Label color is now specifiable per-axis. Also, I <3 jquery.
Robert Konigsberg [Mon, 31 Dec 2012 18:27:14 +0000 (13:27 -0500)]
axisLabelFontSize can now be configured per-axis.
Robert Konigsberg [Mon, 31 Dec 2012 18:27:14 +0000 (13:27 -0500)]
axisLabelFontSize can now be configured per-axis.
Robert Konigsberg [Mon, 31 Dec 2012 17:10:03 +0000 (12:10 -0500)]
The "to hash" textbox now accepts changes in the palette.
Robert Konigsberg [Mon, 31 Dec 2012 17:10:03 +0000 (12:10 -0500)]
The "to hash" textbox now accepts changes in the palette.
Robert Konigsberg [Mon, 31 Dec 2012 15:48:25 +0000 (10:48 -0500)]
Now you can specify the axis a series lives on in the palette.
Robert Konigsberg [Mon, 31 Dec 2012 15:48:25 +0000 (10:48 -0500)]
Now you can specify the axis a series lives on in the palette.
Robert Konigsberg [Sun, 30 Dec 2012 16:24:02 +0000 (11:24 -0500)]
Whoops, small bug in https://github.com/danvk/dygraphs/pull/186/files; it always fails unless you also built the documentation along with i t. This prevents an error.
Robert Konigsberg [Sun, 30 Dec 2012 16:07:00 +0000 (11:07 -0500)]
Merge branch 'master' of github.com:danvk/dygraphs
Conflicts:
auto_tests/tests/Util.js
auto_tests/tests/axis_labels.js
Dan Vanderkam [Sun, 30 Dec 2012 15:32:30 +0000 (07:32 -0800)]
Merge pull request #191 from kberg/option-consolidation
Option consolidation
Robert Konigsberg [Sun, 30 Dec 2012 02:00:42 +0000 (21:00 -0500)]
Options now include defaults. Fix https://code.google.com/p/dygraphs/issues/detail?id=413
Robert Konigsberg [Sun, 30 Dec 2012 01:49:15 +0000 (20:49 -0500)]
Merge branch 'master' of https://github.com/danvk/dygraphs into option-consolidation
Robert Konigsberg [Sun, 30 Dec 2012 01:47:11 +0000 (20:47 -0500)]
Simplify valueRange work in computeYAxes. Add comment indicating its weirdness.
Robert Konigsberg [Sun, 30 Dec 2012 01:11:08 +0000 (20:11 -0500)]
Remove more options. Tested them, either manually, or written, but as you can see by the tests, there are some things left to be desired.
Almost done with option removal from computeYAxes, though, which is really good.
Robert Konigsberg [Sat, 29 Dec 2012 18:23:02 +0000 (13:23 -0500)]
Move makeNumbers to Util, and reduce number of makeNumbers calls.
Robert Konigsberg [Sat, 29 Dec 2012 17:40:37 +0000 (12:40 -0500)]
Merge branch 'master' of https://github.com/danvk/dygraphs
Robert Konigsberg [Sat, 29 Dec 2012 17:39:23 +0000 (12:39 -0500)]
Merge branch 'option-consolidation' of https://github.com/kberg/dygraphs
Robert Konigsberg [Sat, 29 Dec 2012 04:11:24 +0000 (20:11 -0800)]
Merge pull request #190 from kberg/palette
Make palette support axes and series configuration.
Robert Konigsberg [Sat, 29 Dec 2012 04:11:00 +0000 (20:11 -0800)]
Merge pull request #186 from kberg/master
Fix issue http://code.google.com/p/dygraphs/issues/detail?id=409
Robert Konigsberg [Sat, 29 Dec 2012 04:01:54 +0000 (23:01 -0500)]
jqueryify tooltip.
Robert Konigsberg [Sat, 29 Dec 2012 03:39:26 +0000 (22:39 -0500)]
jquery-ify the palette object.