dygraphs.git
11 years agoMerge pull request #237 from kberg/closure
Robert Konigsberg [Thu, 18 Apr 2013 15:35:59 +0000 (08:35 -0700)]
Merge pull request #237 from kberg/closure

Fix closure bugs in Dygraphs

11 years agoFollow-on to pull request 237, closurifying some code.
Robert Konigsberg [Thu, 18 Apr 2013 15:34:18 +0000 (11:34 -0400)]
Follow-on to pull request 237, closurifying some code.

11 years agoMerge pull request #242 from sauter-hq/draw-xaxis-bugfix
Dan Vanderkam [Wed, 17 Apr 2013 21:52:58 +0000 (14:52 -0700)]
Merge pull request #242 from sauter-hq/draw-xaxis-bugfix

BUGFIX: RangeSelector: xAxisLabelHeight is set to 0 in case the option 'drawXAxis' is set to false.

11 years agoReponses to code review for https://github.com/danvk/dygraphs/pull/237
Robert Konigsberg [Tue, 16 Apr 2013 14:26:50 +0000 (10:26 -0400)]
Reponses to code review for https://github.com/danvk/dygraphs/pull/237

11 years agoMerge branch 'master' of github.com:danvk/dygraphs into closure
Robert Konigsberg [Tue, 16 Apr 2013 14:15:18 +0000 (10:15 -0400)]
Merge branch 'master' of github.com:danvk/dygraphs into closure

Conflicts:
dygraph-options.js

11 years agoBUGFIX: Fixed typo
David Eberlein [Tue, 16 Apr 2013 07:07:04 +0000 (09:07 +0200)]
BUGFIX: Fixed typo

11 years agoTEST: Added example of range selector without the chart.
David Eberlein [Fri, 12 Apr 2013 12:51:37 +0000 (14:51 +0200)]
TEST: Added example of range selector without the chart.

11 years agoTEST: Added automated test proving the bugfix made.
David Eberlein [Fri, 12 Apr 2013 12:51:16 +0000 (14:51 +0200)]
TEST: Added automated test proving the bugfix made.

11 years agoMerge pull request #233 from lucasbergman/master
Dan Vanderkam [Thu, 11 Apr 2013 15:54:50 +0000 (08:54 -0700)]
Merge pull request #233 from lucasbergman/master

some small Closure-cleanliness fixes

11 years agoBUGFIX: xAxisLabelHeight is set to 0 in case the option 'drawXAxis' is
eichsjul [Wed, 20 Mar 2013 14:50:58 +0000 (15:50 +0100)]
BUGFIX: xAxisLabelHeight is set to 0 in case the option 'drawXAxis' is
set to false.

11 years agoMerge pull request #240 from timeu/bugfix_upstream
Dan Vanderkam [Tue, 9 Apr 2013 15:49:46 +0000 (08:49 -0700)]
Merge pull request #240 from timeu/bugfix_upstream

Bugfix: Avoid exception when returning the index of the point and one or more series are hidden

11 years agoBugfix: avoid exception when one series is hidden
Uemit Seren [Tue, 9 Apr 2013 07:11:34 +0000 (09:11 +0200)]
Bugfix: avoid exception when one series is hidden

11 years agoMerge pull request #239 from timeu/bugfix_upstream
Dan Vanderkam [Sat, 6 Apr 2013 15:13:36 +0000 (08:13 -0700)]
Merge pull request #239 from timeu/bugfix_upstream

#Issue 333: Pass point index to drawHighlightPointCallback and drawPointCallback

11 years agoFixed minor issues
Uemit Seren [Fri, 5 Apr 2013 12:24:25 +0000 (14:24 +0200)]
Fixed minor issues

11 years agoAdded test for passing the correct idx to pointDrawCallback and hightlightPointDrawCa...
Uemit Seren [Thu, 4 Apr 2013 14:37:38 +0000 (16:37 +0200)]
Added test for passing the correct idx to pointDrawCallback and hightlightPointDrawCallback

11 years agoCode formatting
Uemit Seren [Thu, 4 Apr 2013 14:37:01 +0000 (16:37 +0200)]
Code formatting

11 years agoAdded idx parameter to option-reference
Uemit Seren [Thu, 4 Apr 2013 14:32:28 +0000 (16:32 +0200)]
Added idx parameter to option-reference

11 years ago#Bug 333: Support for passing point index to drawPointCallback and drawHighlightPoint...
Uemit Seren [Wed, 3 Apr 2013 12:45:36 +0000 (14:45 +0200)]
#Bug 333: Support for passing point index to drawPointCallback and drawHighlightPointCallback added

11 years agoMake dygraph-options.js warning-free under Closure Compiler
Lucas Bergman [Thu, 7 Mar 2013 21:30:18 +0000 (15:30 -0600)]
Make dygraph-options.js warning-free under Closure Compiler

11 years agodygraph-utils.js: Make Dygraph.error and Dygraph.update public
Lucas Bergman [Thu, 7 Mar 2013 21:28:47 +0000 (15:28 -0600)]
dygraph-utils.js: Make Dygraph.error and Dygraph.update public

These seem like reasonable utility functions, and they were used outside
of Dygraph (specifically in DygraphOptions). Making these non-private
resolves Closure Compiler warnings inside dygraph-options.js.

11 years agodygraph-utils.js: Remove trailing white space
Lucas Bergman [Thu, 7 Mar 2013 18:32:53 +0000 (12:32 -0600)]
dygraph-utils.js: Remove trailing white space

11 years agodygraph-tickers.js: Fix variable redeclaration
Lucas Bergman [Wed, 6 Mar 2013 21:24:05 +0000 (15:24 -0600)]
dygraph-tickers.js: Fix variable redeclaration

11 years agodygraph-utils.js: isElementContainedBy -> isNodeContainedBy
Lucas Bergman [Wed, 6 Mar 2013 21:02:33 +0000 (15:02 -0600)]
dygraph-utils.js: isElementContainedBy -> isNodeContainedBy

This fixes a type nit when using the Closure Compiler, since walking
parentNode can give an Element or Document node, not just an Element.

11 years agoSome closurifying dygraph-canvas and dygraph-layout.
Robert Konigsberg [Sat, 30 Mar 2013 11:39:03 +0000 (07:39 -0400)]
Some closurifying dygraph-canvas and dygraph-layout.

11 years agoMerge pull request #238 from kberg/master
Robert Konigsberg [Sat, 30 Mar 2013 11:10:29 +0000 (04:10 -0700)]
Merge pull request #238 from kberg/master

Add test suite for DygraphOptions object. Fix broken method in it.

11 years agoAdd test suite for DygraphOptions object. Fix broken method in it.
Robert Konigsberg [Sat, 30 Mar 2013 11:07:34 +0000 (07:07 -0400)]
Add test suite for DygraphOptions object. Fix broken method in it.

11 years agoClosurize rgbcolor.js
Robert Konigsberg [Sat, 30 Mar 2013 02:18:55 +0000 (22:18 -0400)]
Closurize rgbcolor.js

11 years agoClosure fix type Dyraph->Dygraph.
Robert Konigsberg [Sat, 30 Mar 2013 02:07:11 +0000 (22:07 -0400)]
Closure fix type Dyraph->Dygraph.

11 years agoClosurize dygraph-options.js. Not done.
Robert Konigsberg [Sat, 30 Mar 2013 02:02:09 +0000 (22:02 -0400)]
Closurize dygraph-options.js. Not done.

Also fix bug: this.labels_ was never used! Booo...

11 years agoClosure tweak: variable 'd' declared twice within the same method.
Robert Konigsberg [Fri, 29 Mar 2013 22:44:07 +0000 (18:44 -0400)]
Closure tweak: variable 'd' declared twice within the same method.

11 years agoClosure fix; force cast from Element to Node.
Robert Konigsberg [Fri, 29 Mar 2013 22:41:43 +0000 (18:41 -0400)]
Closure fix; force cast from Element to Node.

11 years agoMerge pull request #234 from wimme/patch-2
Dan Vanderkam [Thu, 7 Mar 2013 17:58:17 +0000 (09:58 -0800)]
Merge pull request #234 from wimme/patch-2

Fix in Dygraph.log for IE8

11 years agoFix in Dygraph.log for IE8
Wim Bruynooghe [Thu, 7 Mar 2013 08:52:54 +0000 (09:52 +0100)]
Fix in Dygraph.log for IE8

In IE8, the console.log functions aren't true Javascript functions. They don't support the "apply" or "call" methods.

All Javascript code stopped working when a log message was being generated, therefor this small fix.

11 years agoMerge pull request #226 from vlsi/wrong_stacked_computation
Dan Vanderkam [Sat, 2 Mar 2013 17:49:47 +0000 (09:49 -0800)]
Merge pull request #226 from vlsi/wrong_stacked_computation

Fixed computation of stacked series in case some series start in the mid...

11 years agoMerge pull request #231 from paulfelix/master
Robert Konigsberg [Wed, 27 Feb 2013 01:52:30 +0000 (17:52 -0800)]
Merge pull request #231 from paulfelix/master

Fix for Issue 439: Dragging a range Selector grab handle is not working properly when graph's position on page is offset

11 years agoFix for issue #439
Paul Felix [Tue, 26 Feb 2013 22:01:03 +0000 (17:01 -0500)]
Fix for issue #439

11 years agoMerge pull request #230 from clocksmith/master
Robert Konigsberg [Tue, 26 Feb 2013 20:31:19 +0000 (12:31 -0800)]
Merge pull request #230 from clocksmith/master

Fix broken test file

11 years agoFix syntax error in callback.js
clocksmith [Tue, 26 Feb 2013 20:02:04 +0000 (15:02 -0500)]
Fix syntax error in callback.js

11 years agoMerge pull request #229 from clocksmith/master
Robert Konigsberg [Tue, 26 Feb 2013 18:37:06 +0000 (10:37 -0800)]
Merge pull request #229 from clocksmith/master

Fix the bug intorduced from adding ypad and ypadCompat to no longer return NaN values for the yAxisRange. Test added to guarantee that the underlay callback is called even when there are no series and that the yAxisRange is valid.

11 years agoAdded tests for explicit y axis range in callback.
clocksmith [Tue, 26 Feb 2013 18:26:46 +0000 (13:26 -0500)]
Added tests for explicit y axis range in callback.

11 years agoFix value of yMax in callback.js test.
clocksmith [Mon, 25 Feb 2013 17:58:36 +0000 (12:58 -0500)]
Fix value of yMax in callback.js test.

11 years agoMerge branch 'master' of https://github.com/danvk/dygraphs
clocksmith [Mon, 25 Feb 2013 17:42:44 +0000 (12:42 -0500)]
Merge branch 'master' of https://github.com/danvk/dygraphs

11 years agoAdd tests for underlayCallback with no series.
clocksmith [Mon, 25 Feb 2013 16:58:15 +0000 (11:58 -0500)]
Add tests for underlayCallback with no series.

11 years agoFixed computation of stacked series in case some series start in the middle of the...
Vladimir Sitnikov [Sun, 24 Feb 2013 20:43:35 +0000 (00:43 +0400)]
Fixed computation of stacked series in case some series start in the middle of the range
The bug is caused by stale value of last_x local across loop in gatherDatasets_.
See https://code.google.com/p/dygraphs/issues/detail?id=438

11 years agoMerge pull request #225 from vlsi/master
Dan Vanderkam [Sun, 24 Feb 2013 22:43:40 +0000 (14:43 -0800)]
Merge pull request #225 from vlsi/master

Fix wrong values in legend when using stackedGraph with missing values

11 years agoMerge pull request #224 from kberg/i294
Dan Vanderkam [Sun, 24 Feb 2013 22:43:07 +0000 (14:43 -0800)]
Merge pull request #224 from kberg/i294

Use the correct access when computing bounded y-values for constrained panning.

11 years agoFix wrong values in legend when using stackedGraph with missing values
Vladimir Sitnikov [Sun, 24 Feb 2013 20:31:19 +0000 (00:31 +0400)]
Fix wrong values in legend when using stackedGraph with missing values
Consider all the series when searching previous stacked one and use Dygraph.isValidPoint to validate the point (not just !yval)
See http://jsfiddle.net/6W7EQ/2/

11 years agoUse the correct access when computing bounded y-values for constrained panning.
Robert Konigsberg [Sun, 24 Feb 2013 07:08:43 +0000 (02:08 -0500)]
Use the correct access when computing bounded y-values for constrained panning.

Dygraphs was computing the second y-axis using extreme range of the first y-axis. This fixes bug 294, setting panEdgeFraction to non-zero breaks secondary y-axis label computation.

Also add a minor optimization by moving a computation outside the axis loop.

11 years agoi
clocksmith [Sat, 23 Feb 2013 00:19:26 +0000 (19:19 -0500)]
i

11 years agoi
clocksmith [Fri, 22 Feb 2013 22:52:40 +0000 (17:52 -0500)]
i

11 years agoMerge pull request #222 from kberg/master
Dan Vanderkam [Thu, 21 Feb 2013 22:03:48 +0000 (14:03 -0800)]
Merge pull request #222 from kberg/master

Fix bug 436, and include a lint change.

11 years agoFix bug 436. Only restore axes that remain after an option update.
Robert Konigsberg [Thu, 21 Feb 2013 20:46:01 +0000 (15:46 -0500)]
Fix bug 436. Only restore axes that remain after an option update.

11 years agoTemporarily disable tests which must be run in eastern time
Dan Vanderkam [Wed, 20 Feb 2013 17:22:39 +0000 (12:22 -0500)]
Temporarily disable tests which must be run in eastern time

11 years agoMerge branch 'master' of github.com:danvk/dygraphs
Dan Vanderkam [Wed, 20 Feb 2013 16:52:09 +0000 (11:52 -0500)]
Merge branch 'master' of github.com:danvk/dygraphs

11 years agoFix an issue where annotations are set too early in IE8
Dan Vanderkam [Wed, 20 Feb 2013 16:51:53 +0000 (11:51 -0500)]
Fix an issue where annotations are set too early in IE8

11 years agoFix & regression test for issue 392: connectSeparated and errorBars don't play nicely...
Dan Vanderkam [Wed, 20 Feb 2013 04:08:40 +0000 (23:08 -0500)]
Fix & regression test for issue 392: connectSeparated and errorBars don't play nicely together

11 years agoadd note about IE8
Dan Vanderkam [Wed, 20 Feb 2013 03:13:56 +0000 (22:13 -0500)]
add note about IE8

11 years agoguard window.getComputedStyle call for IE8
Dan Vanderkam [Wed, 20 Feb 2013 01:18:54 +0000 (20:18 -0500)]
guard window.getComputedStyle call for IE8

11 years agoMerge pull request #221 from walkingeyerobot/master
Dan Vanderkam [Tue, 19 Feb 2013 21:24:31 +0000 (13:24 -0800)]
Merge pull request #221 from walkingeyerobot/master

can't change constants

11 years agoSince we can't change constants, checking to see if they exist instead of always...
Mitch Foley [Tue, 19 Feb 2013 21:21:44 +0000 (16:21 -0500)]
Since we can't change constants, checking to see if they exist instead of always changing the value.

11 years agogetComputedStyle -> window.getComputedStyle
Dan Vanderkam [Tue, 19 Feb 2013 20:55:35 +0000 (15:55 -0500)]
getComputedStyle -> window.getComputedStyle

11 years agoMerge pull request #220 from walkingeyerobot/master
Dan Vanderkam [Tue, 19 Feb 2013 19:42:17 +0000 (11:42 -0800)]
Merge pull request #220 from walkingeyerobot/master

adding missing license block to dygraph-options.js

11 years agoadding missing license block
Mitch Foley [Tue, 19 Feb 2013 18:10:54 +0000 (13:10 -0500)]
adding missing license block

11 years agoIgnore zooms entirely outisde the plot area; Fix broken tests.
Dan Vanderkam [Mon, 18 Feb 2013 23:31:12 +0000 (18:31 -0500)]
Ignore zooms entirely outisde the plot area; Fix broken tests.

11 years agoClean up some zooming oddities; fixes issues 434 and 280
Dan Vanderkam [Mon, 18 Feb 2013 20:32:21 +0000 (15:32 -0500)]
Clean up some zooming oddities; fixes issues 434 and 280

11 years agokberg review comments
Dan Vanderkam [Mon, 18 Feb 2013 20:01:42 +0000 (15:01 -0500)]
kberg review comments

11 years agoFix & regression test for issue 433: Glitch in two-hourly ticks when crossing a ...
Dan Vanderkam [Mon, 18 Feb 2013 05:31:54 +0000 (00:31 -0500)]
Fix & regression test for issue 433: Glitch in two-hourly ticks when crossing a "spring forward" daylight savings switch

11 years agoOne more case in which ticks across DST boundaries are still broken
Dan Vanderkam [Mon, 18 Feb 2013 05:02:49 +0000 (00:02 -0500)]
One more case in which ticks across DST boundaries are still broken

11 years agoA few tweaks to make all tests pass on FF 3.5
Dan Vanderkam [Mon, 18 Feb 2013 04:24:15 +0000 (23:24 -0500)]
A few tweaks to make all tests pass on FF 3.5

11 years agofactor out Dygraph.setDateSameTZ
Dan Vanderkam [Mon, 18 Feb 2013 02:37:02 +0000 (21:37 -0500)]
factor out Dygraph.setDateSameTZ

11 years agoFix some more DST issues
Dan Vanderkam [Mon, 18 Feb 2013 02:17:51 +0000 (21:17 -0500)]
Fix some more DST issues

11 years agoFix and regression test for Issue 147: X-axis date labels break after DST transitions
Dan Vanderkam [Mon, 18 Feb 2013 01:13:07 +0000 (20:13 -0500)]
Fix and regression test for Issue 147: X-axis date labels break after DST transitions

11 years agoReturn failure code when lint fails.
Robert Konigsberg [Sun, 17 Feb 2013 12:57:33 +0000 (07:57 -0500)]
Return failure code when lint fails.

11 years agoFix & regression test for issue 363: Calling setSelection() after an updateOptions...
Dan Vanderkam [Sun, 17 Feb 2013 04:36:15 +0000 (23:36 -0500)]
Fix & regression test for issue 363: Calling setSelection() after an updateOptions may have no effect

11 years agofix & regression test for issue 355: Row number Issue
Dan Vanderkam [Sun, 17 Feb 2013 04:17:05 +0000 (23:17 -0500)]
fix & regression test for issue 355: Row number Issue

11 years agoFix a few lint errors
Dan Vanderkam [Sun, 17 Feb 2013 03:33:46 +0000 (22:33 -0500)]
Fix a few lint errors

11 years agoMove KMB/KMG2 formatting into default formatter function (issue 414)
Dan Vanderkam [Sun, 17 Feb 2013 03:27:18 +0000 (22:27 -0500)]
Move KMB/KMG2 formatting into default formatter function (issue 414)

11 years agoFix issue 176, which involved duplicated x-values in stacked graphs
Dan Vanderkam [Sun, 17 Feb 2013 02:36:58 +0000 (21:36 -0500)]
Fix issue 176, which involved duplicated x-values in stacked graphs

11 years agoAdd another test for DST transitions
Dan Vanderkam [Sun, 17 Feb 2013 00:40:53 +0000 (19:40 -0500)]
Add another test for DST transitions

11 years agoRegression test for issue 430: Incorrect rendering when all values are negative and...
Dan Vanderkam [Sat, 16 Feb 2013 20:07:41 +0000 (15:07 -0500)]
Regression test for issue 430: Incorrect rendering when all values are negative and the same

11 years agoMerge pull request #210 from klausw-g/range-pad-2
Dan Vanderkam [Sat, 16 Feb 2013 19:50:27 +0000 (11:50 -0800)]
Merge pull request #210 from klausw-g/range-pad-2

Add new options xRangePad and yRangePad

11 years agoMerge pull request #216 from klausw-g/issue-424-b
Dan Vanderkam [Sat, 16 Feb 2013 16:50:54 +0000 (08:50 -0800)]
Merge pull request #216 from klausw-g/issue-424-b

Re-do the fix for stacked graph highlighting

11 years agoMerge pull request #217 from paulfelix/master
Dan Vanderkam [Sat, 16 Feb 2013 16:32:29 +0000 (08:32 -0800)]
Merge pull request #217 from paulfelix/master

Fix for Issue 378: Mouse gradually drifts off of range selection handle

11 years agoMerge pull request #218 from walkingeyerobot/master
Dan Vanderkam [Fri, 15 Feb 2013 20:48:39 +0000 (12:48 -0800)]
Merge pull request #218 from walkingeyerobot/master

Make dygraph-tickers more independent

11 years agorv 34ad56b341, which introduced issue 432
Dan Vanderkam [Fri, 15 Feb 2013 20:34:08 +0000 (15:34 -0500)]
rv 34ad56b341, which introduced issue 432

11 years agoMaking dygraph-tickers.js slightly more independent.
Mitch Foley [Fri, 15 Feb 2013 20:08:43 +0000 (15:08 -0500)]
Making dygraph-tickers.js slightly more independent.

11 years agocode review: rename to .singleSeriesName
Klaus Weidner [Tue, 12 Feb 2013 18:19:20 +0000 (10:19 -0800)]
code review: rename to .singleSeriesName

11 years agoCall addEvent on graph instance where needed for auto removal
Paul Felix [Tue, 12 Feb 2013 17:24:49 +0000 (12:24 -0500)]
Call addEvent on graph instance where needed for auto removal

11 years agoMerge branch 'master' of github.com:danvk/dygraphs
Paul Felix [Tue, 12 Feb 2013 15:10:32 +0000 (10:10 -0500)]
Merge branch 'master' of github.com:danvk/dygraphs

11 years agoFix for Issue 378: Mouse gradually drifts off of range selection handle
Paul Felix [Tue, 12 Feb 2013 15:09:58 +0000 (10:09 -0500)]
Fix for Issue 378: Mouse gradually drifts off of range selection handle

11 years agoadd missing semicolon
Dan Vanderkam [Mon, 11 Feb 2013 16:52:25 +0000 (11:52 -0500)]
add missing semicolon

11 years agoMerge branch 'master' of github.com:danvk/dygraphs
Dan Vanderkam [Mon, 11 Feb 2013 02:04:46 +0000 (21:04 -0500)]
Merge branch 'master' of github.com:danvk/dygraphs

11 years agoadd Great Lakes Water Level dashboard example
Dan Vanderkam [Mon, 11 Feb 2013 02:04:39 +0000 (21:04 -0500)]
add Great Lakes Water Level dashboard example

11 years agoRe-do the fix for stacked graph highlighting
Klaus Weidner [Mon, 11 Feb 2013 00:53:07 +0000 (16:53 -0800)]
Re-do the fix for stacked graph highlighting

This reverts the change from https://github.com/danvk/dygraphs/pull/211
and instead provides a boolean arg to the plotter so that it can decide
not to draw if needed.

The problem with the approach from #211 is that this prevents error bars
from being highlighted, and those should be redrawn on mouseover.

Fixes issue 424.

11 years agoAddress code review comments
Klaus Weidner [Sun, 10 Feb 2013 23:10:06 +0000 (15:10 -0800)]
Address code review comments

11 years agoRemove naming of anoymous functions. Unnecessary and slightly wrong.
Robert Konigsberg [Sun, 10 Feb 2013 16:43:22 +0000 (11:43 -0500)]
Remove naming of anoymous functions. Unnecessary and slightly wrong.

11 years agoMerge pull request #213 from kberg/i329
Dan Vanderkam [Sat, 9 Feb 2013 22:29:04 +0000 (14:29 -0800)]
Merge pull request #213 from kberg/i329

Fix bug 329 which accumulates clipping rectangles on subsequent draws.

11 years agoFix bug 329 which accumulates clipping rectangles on subsequent draws.
Robert Konigsberg [Sat, 9 Feb 2013 19:14:09 +0000 (14:14 -0500)]
Fix bug 329 which accumulates clipping rectangles on subsequent draws.

11 years agoMerge pull request #211 from klausw-g/issue-424
Dan Vanderkam [Sat, 9 Feb 2013 05:48:42 +0000 (21:48 -0800)]
Merge pull request #211 from klausw-g/issue-424

Don't redraw graph stack in interactive highlight

11 years agoMerge pull request #212 from kberg/i153
Dan Vanderkam [Sat, 9 Feb 2013 05:30:38 +0000 (21:30 -0800)]
Merge pull request #212 from kberg/i153

Fix bug 153, findPosX and findPosY don't take borders into account. This...