Klaus Weidner [Fri, 2 Mar 2012 21:09:47 +0000 (13:09 -0800)]
Fix connectSeparatedPoints, add test
The original connectSeparatedPoints code renumbered points within series, with the effect that 'row' as used in setSelection didn't work as expected - it selects unrelated points.
This change keeps the point numbering intact, and instead moves the logic to skip missing points to the canvas renderer and setSelection().
A new auto_test confirms this behavior.
Klaus Weidner [Fri, 2 Mar 2012 18:40:14 +0000 (10:40 -0800)]
Merge branch 'master' into highlight-stacked
Robert Konigsberg [Fri, 2 Mar 2012 02:52:32 +0000 (18:52 -0800)]
Merge pull request #138 from klausw-g/highlight-series-gallery
Pulled this in, thanks! (Dan, do lmk if this is an issue)
Add closest-series highlighting demo to gallery
Klaus Weidner [Fri, 2 Mar 2012 02:49:08 +0000 (18:49 -0800)]
Add closest-series highlighting demo to gallery
This is a port of tests/series-highlight.html.
Klaus Weidner [Thu, 1 Mar 2012 18:57:01 +0000 (10:57 -0800)]
Fix highlighting for zoomed graphs
The code wasn't correctly applying the left boundary offset when converting a row index in the pruned data to/from a row index for the full data set.
Add a getLeftBoundary_ helper method and replace the existing loops that attempted to find the first defined record. Not sure why it saves multiple boundaryIds anyway, the code assumes it can just use the first one.
Also fix an apparently-invalid usage in getSelection().
Klaus Weidner [Thu, 1 Mar 2012 03:25:11 +0000 (19:25 -0800)]
Keep the X axis ticks when logscale is set globally.
Currently, setting {logscale: true} at the toplevel options with a
numeric X axis attempts to use logarithmic ticks for the X axis too,
with strange results since the X values aren't scaled logarithmically.
This resulted in tests/logscale.html skipping the "6" and "8" numbers on
the ticker, and the modified demo with a large X value shows the effect
more clearly.
This change wraps the numericTicks generator as numericLinearTicks,
ignoring 'logscale' in its axis options, and uses that for the X axis
numeric ticker. Arguably doing it the other way around would be clearer,
but that would be a much larger refactoring.
(Note that date-valued X axes as used in the stock demo weren't affected
by this issue.)
Dan Vanderkam [Wed, 29 Feb 2012 19:23:01 +0000 (11:23 -0800)]
Merge pull request #135 from klausw-g/highlight-NaN-3
New approach to fix NaN handling in highlighting
Klaus Weidner [Wed, 29 Feb 2012 18:15:50 +0000 (10:15 -0800)]
New approach to fix NaN handling in highlighting
Dan Vanderkam [Wed, 29 Feb 2012 17:50:35 +0000 (09:50 -0800)]
Merge pull request #134 from timeu/bugfix_upstream
Bugfix: Avoid getting stuck when the first datapoint has a NaN value
Dan Vanderkam [Wed, 29 Feb 2012 17:38:12 +0000 (09:38 -0800)]
Merge pull request #133 from klausw-g/fix-stuck-highlighting
Fix stuck fading animation for series highlighting
Uemit Seren [Wed, 29 Feb 2012 15:58:14 +0000 (16:58 +0100)]
Bugfix: Avoid getting stuck when the first datapoint has a NaN value
Robert Konigsberg [Wed, 29 Feb 2012 00:34:29 +0000 (19:34 -0500)]
Merge branch 'master' of https://github.com/danvk/dygraphs
Robert Konigsberg [Wed, 29 Feb 2012 00:12:25 +0000 (19:12 -0500)]
Rename stuff.
Klaus Weidner [Wed, 29 Feb 2012 00:06:32 +0000 (16:06 -0800)]
Fix stuck fading animation for series highlighting
The animateId field wasn't being initialized correctly if
clearSelection() got called before the first call to setSelection().
TODO(klausw): add more generic support for animating changes to option
values?
Robert Konigsberg [Wed, 29 Feb 2012 00:10:24 +0000 (19:10 -0500)]
Clean up docs a little, fix "title" propagation bug.
Dan Vanderkam [Tue, 28 Feb 2012 20:23:00 +0000 (12:23 -0800)]
Merge pull request #131 from klausw-g/highlight-NaN-2
Fix NaN values confusing closest-point search
Klaus Weidner [Tue, 28 Feb 2012 18:34:57 +0000 (10:34 -0800)]
Merge branch 'master' into highlight-NaN-2
Robert Konigsberg [Tue, 28 Feb 2012 11:48:22 +0000 (06:48 -0500)]
Reorder; trying to move to Gallery
Robert Konigsberg [Tue, 28 Feb 2012 11:40:29 +0000 (06:40 -0500)]
Update index.html to mention the gallery
Robert Konigsberg [Tue, 28 Feb 2012 11:31:46 +0000 (06:31 -0500)]
More name standardization.
Robert Konigsberg [Tue, 28 Feb 2012 11:24:55 +0000 (06:24 -0500)]
Doc updates / push gallery, rename some gallery js files for compatibility.
Klaus Weidner [Tue, 28 Feb 2012 04:36:01 +0000 (20:36 -0800)]
Fix NaN values confusing closest-point search
The current algorithm was not handling NaN values right, the "dist >= max"
check is false for dist=NaN and led to the "this point is closer" branch
being taken. Fix this by reversing the if logic, and add a regression
test for it. (I confirmed that the test fails for the original code,
and passes after the change.)
Robert Konigsberg [Tue, 28 Feb 2012 03:11:11 +0000 (22:11 -0500)]
Remove deleted tests from index.html
Robert Konigsberg [Tue, 28 Feb 2012 03:09:04 +0000 (22:09 -0500)]
Delete outdated tests.
Robert Konigsberg [Tue, 28 Feb 2012 03:06:27 +0000 (22:06 -0500)]
Fix option reference, remove line continuation hack.
Dan Vanderkam [Tue, 28 Feb 2012 00:17:03 +0000 (16:17 -0800)]
Merge pull request #129 from klausw-g/tweak-circle-demo
tweak custom circle demo to add per-series highlighting
Klaus Weidner [Mon, 27 Feb 2012 22:55:54 +0000 (14:55 -0800)]
Add a simple demo as a self-contained example
The fancy demos are useful to show off the supported possibilities, but
not as helpful for people who just want to switch on the feature.
Klaus Weidner [Sun, 26 Feb 2012 04:48:29 +0000 (20:48 -0800)]
tweak custom circle demo to add per-series highlighting
Also refactor the demo to automatically use all exported functions
in Dygraph.Circles instead of harcoding a list.
Dan Vanderkam [Mon, 27 Feb 2012 21:47:37 +0000 (13:47 -0800)]
Merge pull request #126 from klausw-g/highlight3
Add support for closest-series highlighting
Klaus Weidner [Mon, 27 Feb 2012 18:31:16 +0000 (10:31 -0800)]
Change option to highlightSeriesBackgroundAlpha
This is 1 - highlightSeriesBackgroundFade (using the old option), and hopefully more intuitive.
Klaus Weidner [Mon, 27 Feb 2012 18:24:31 +0000 (10:24 -0800)]
Changes based on danvk's review:
- turn on background fading by default, remove extra animation option.
- clarify docstrings for closest-point finding methods.
Dan Vanderkam [Mon, 27 Feb 2012 16:51:55 +0000 (08:51 -0800)]
Merge pull request #128 from klausw-g/custom-circle-tweaks
Custom circle tweaks:
Dan Vanderkam [Mon, 27 Feb 2012 16:23:08 +0000 (11:23 -0500)]
whitespace cleanup
Dan Vanderkam [Mon, 27 Feb 2012 16:21:11 +0000 (08:21 -0800)]
Merge pull request #125 from jllodra/master
fixed: css3 labelsDivStyles crashed in IE8
Robert Konigsberg [Mon, 27 Feb 2012 14:09:55 +0000 (09:09 -0500)]
Gallery failure when CSS does not exist.
Robert Konigsberg [Mon, 27 Feb 2012 13:04:37 +0000 (08:04 -0500)]
Gallery code links reset the URL anchor. This fixes it.
Klaus Weidner [Sun, 26 Feb 2012 04:38:40 +0000 (20:38 -0800)]
clean up closePath usage
I was confused by a wrong example I saw online, it's supposed to be used
before stroke() as it was in the original version. It's not needed
after fill() since that automatically closes the path.
Klaus Weidner [Sun, 26 Feb 2012 01:46:50 +0000 (17:46 -0800)]
Custom circle tweaks:
- use stroke + fill with white background for circles and polygons
- set the context to use the current strokeWidth and color by default,
and keep this line width for the standard single-colored symbols.
Override it as needed (for example for the smiley demo).
Klaus Weidner [Sun, 26 Feb 2012 01:11:27 +0000 (17:11 -0800)]
Tweak series-highlight demo
Klaus Weidner [Sun, 26 Feb 2012 00:04:41 +0000 (16:04 -0800)]
Merge branch 'master' of git://github.com/danvk/dygraphs into highlight3
Robert Konigsberg [Sat, 25 Feb 2012 21:48:47 +0000 (13:48 -0800)]
Merge pull request #127 from kberg/master
Clean up gallery; show HTML, Javascript and CSS in prettier fashion.
Robert Konigsberg [Sat, 25 Feb 2012 21:45:10 +0000 (16:45 -0500)]
Display CSS. This doesn't work in Chrome, locally (code.google.com/p/chromium/issues/detail?id=45786). Well it works with FF, and also should work when published.
Robert Konigsberg [Sat, 25 Feb 2012 20:40:17 +0000 (15:40 -0500)]
Updated docs for drawPointCallback and drawHighlightPointCallback.
Klaus Weidner [Sat, 25 Feb 2012 20:32:06 +0000 (12:32 -0800)]
Add demo for series highlighting
Robert Konigsberg [Sat, 25 Feb 2012 20:21:15 +0000 (15:21 -0500)]
Support line continuation in JSON format.
Klaus Weidner [Sat, 25 Feb 2012 20:18:26 +0000 (12:18 -0800)]
Merge branch 'master' of git://github.com/danvk/dygraphs into highlight3
Conflicts:
auto_tests/tests/callback.js
dygraph-canvas.js
dygraph-options-reference.js
Klaus Weidner [Sat, 25 Feb 2012 19:39:15 +0000 (11:39 -0800)]
remove mouseoverCallback and highlightUnderlay from this branch
These were part of a different change and weren't intended to be part of
this pull request, keep them separate for now.
Dan Vanderkam [Sat, 25 Feb 2012 19:38:36 +0000 (11:38 -0800)]
Merge pull request #123 from kberg/custom-points
Custom drawing circles
Klaus Weidner [Sat, 25 Feb 2012 19:37:14 +0000 (11:37 -0800)]
cleanups as requested in kberg's review
Robert Konigsberg [Sat, 25 Feb 2012 09:02:39 +0000 (04:02 -0500)]
Add "parameters" specification to docs; indented rendering.
Klaus Weidner [Sat, 25 Feb 2012 04:01:20 +0000 (20:01 -0800)]
Add support for closest-series highlighting
The new option highlightSeriesOpts applies options such as strokeWidth
to the timeseries that's currently closest to the mouse Y position,
and also passes the name of that timeseries to the highlightCallback.
There's also a new optional seriesName argument to setSelection().
See the new tests in callback.js for examples.
Also add a "highlight" class label to the currently-highlighted
timeseries in the legend view to facilitate styling via CSS.
The new options strokeBorderWidth and strokeBorderColor allow drawing a
border around graph lines to make them stand out better. This is
intended for highlightSeriesOpts, but also works when used for all
lines.
There's also support for background fading for series highlighting,
optionally animated.
New options:
highlightSeriesOpts (default null)
strokeBorderWidth (default 0 == off)
strokeBorderColor (default white)
highlightSeriesBackgroundFade (default 0 == off)
highlightSeriesAnimated (default false)
Robert Konigsberg [Sat, 25 Feb 2012 00:05:50 +0000 (19:05 -0500)]
Better gallery; separates out the HTML, Javascript and CSS. Although the CSS is missing still. :/ Should take me an hour on the weekend to finish.
Robert Konigsberg [Fri, 24 Feb 2012 14:32:49 +0000 (09:32 -0500)]
Remove comma, incompatible with IE.
Josep Llodrà [Fri, 24 Feb 2012 13:50:17 +0000 (14:50 +0100)]
console.warn to this.warn
Josep Llodrà [Fri, 24 Feb 2012 12:09:00 +0000 (13:09 +0100)]
new commit: fix labelsDivStyles IE8
Josep Llodrà [Fri, 24 Feb 2012 12:01:11 +0000 (13:01 +0100)]
Prevent crashing when using unsupported css3 properties for your browser in labelsDivStyles
Robert Konigsberg [Fri, 24 Feb 2012 03:19:06 +0000 (22:19 -0500)]
Changes due to code review.
Dan Vanderkam [Thu, 23 Feb 2012 17:07:55 +0000 (09:07 -0800)]
Merge pull request #121 from wimme/patch-1
Fix for issue 274: broken step plots
Dan Vanderkam [Thu, 23 Feb 2012 17:02:57 +0000 (09:02 -0800)]
Merge pull request #124 from timeu/bugfix_upstream
Fix for bug 284.
Robert Konigsberg [Thu, 23 Feb 2012 15:14:38 +0000 (10:14 -0500)]
Fixed Dygraph.Circles.Circle and custom circles. All working now.
Uemit Seren [Thu, 23 Feb 2012 14:33:12 +0000 (15:33 +0100)]
Bug 284. Check that user_attrs_ and attrs_ !== null and remove mouse event handler in destroy() function
Robert Konigsberg [Thu, 23 Feb 2012 13:50:33 +0000 (08:50 -0500)]
Many bug fixes, highlight seems to not work.
Robert Konigsberg [Thu, 23 Feb 2012 00:21:54 +0000 (19:21 -0500)]
Add custom-circles demo to tests/. Obvious bugs in rendering custom widgets.
Robert Konigsberg [Thu, 23 Feb 2012 00:01:06 +0000 (19:01 -0500)]
Add tests for drawPointCallback and drawHighlightCallback
Robert Konigsberg [Wed, 22 Feb 2012 23:52:15 +0000 (18:52 -0500)]
Add sanity drawPointCallback tests.
Robert Konigsberg [Wed, 22 Feb 2012 23:45:48 +0000 (18:45 -0500)]
whitespace cleanup
Robert Konigsberg [Wed, 22 Feb 2012 14:39:38 +0000 (09:39 -0500)]
Merge github.com/danvk/dygraphs into custom-points
Conflicts:
dygraph-canvas.js
dygraph-utils.js
Robert Konigsberg [Wed, 22 Feb 2012 14:05:49 +0000 (09:05 -0500)]
custom circles, first part.
Robert Konigsberg [Tue, 21 Feb 2012 15:18:46 +0000 (07:18 -0800)]
Merge pull request #120 from timeu/bugfix_upstream
Fix unzooming when valueRange is set and animatedZoom=true
(Thanks!)
Uemit Seren [Tue, 21 Feb 2012 15:16:13 +0000 (16:16 +0100)]
Use DygraphOps.dispatchXXX method instead of updateOptions
wimme [Fri, 17 Feb 2012 10:52:40 +0000 (11:52 +0100)]
Fix for issue 274: broken step plots
Uemit Seren [Thu, 16 Feb 2012 10:08:40 +0000 (11:08 +0100)]
Bug #282. Auto-test added
Uemit Seren [Thu, 16 Feb 2012 10:07:26 +0000 (11:07 +0100)]
Bugfix #282. Use valueRange (if specified) instead of extremes during unzooming. Fixed the check whether the y-axis is dirty
Dan Vanderkam [Wed, 15 Feb 2012 19:22:09 +0000 (11:22 -0800)]
Merge pull request #118 from klausw-g/bug-278
Fix data ordering bug from issue 278, and clean up datasets handling
Klaus Weidner [Tue, 7 Feb 2012 02:42:45 +0000 (18:42 -0800)]
Fix data ordering bug from issue 278, and clean up datasets handling
The code was declaring this.layout_.datasets as an array, assuming
numerical indices, but accessing them as an object using string labels
as keys. This caused problems with Chrome which reorders numeric-looking
string labels, for example sorting "10" before "09".
This changelist redefines datasets to be an array indexed by series
number, and maintains a separate setNames array used in those places
where it's needed.
As part of the refactoring, also change indexFromSetname to use a lookup
instead of looping over all series each time, and provide a getLabels()
convenience function.
Includes a test for this in axis_labels.js that also demonstrates the
bug.
bluthen [Thu, 26 Jan 2012 22:37:43 +0000 (17:37 -0500)]
Support stroke patterns (i.e. dashed/dotted lines).
Patterns can be arbitrarily complicated sequences of lines and breaks,
or pre-built constants like Dygraph.DOTTED_LINE.
See tests/per-series.html for an example of how this works.
commit
214caf668bb8472605c505c124fd14e5d3b5a956
Merge: db2e28c 25c4046
Author: Dan Vanderkam <danvk@google.com>
Date: Thu Jan 26 17:33:08 2012 -0500
Merge branch 'stroke_pattern' of https://github.com/bluthen/dygraphs into bluthen
commit
25c40460bbd25f05cfd0be9da3535dd4662cfadb
Author: Russell Valentine <russ@coldstonelabs.org>
Date: Thu Jan 26 14:43:14 2012 -0600
Few changes suggested by Dan Vanderkam.
commit
a9965f34b5470c2db5656cac1d8d3debd3a0d4e7
Author: Russell Valentine <russ@coldstonelabs.org>
Date: Thu Jan 26 00:41:44 2012 -0600
Stroke patterns in the legend that scale to 1em.
commit
62f2905c52e6936339dd1de7af1844aaced95c05
Author: Russell Valentine <russ@coldstonelabs.org>
Date: Sat Jan 21 12:14:03 2012 -0600
Sets dimensions for graph div in dash test so it could pass if default size ever changes.
commit
bfece39cc4f2e365cf692b81cffdf91a773625ac
Author: Russell Valentine <russ@coldstonelabs.org>
Date: Fri Jan 20 17:22:33 2012 -0600
Added a simple dash unit test. It tests if it draw the correct number of lines
and remembers pattern history between points.
commit
57539c89e29a1e45a6d1000ebe53c496eb88a61b
Author: Russell Valentine <russ@coldstonelabs.org>
Date: Wed Jan 18 23:50:13 2012 -0600
Comment wording changes. Added default string stroke patterns object to allow for more code reuse.
commit
de286626b93dc7ce49ce50abfba83ffaa29db068
Author: Russell Valentine <russ@coldstonelabs.org>
Date: Wed Jan 18 22:48:16 2012 -0600
Use "font-weight: bold" in style instead of the bold tag.
commit
f5958230321df474bfb1339b9a97c64f92f20621
Author: Russell Valentine <russ@coldstonelabs.org>
Date: Wed Jan 18 22:12:50 2012 -0600
Reverted CanvasAssertions.js to have no modifications.
Moved array compare function to dygraph-utils.
Moved dashedLine into DygraphCanvasRenderer instead of in
CanvasRenderingContext2D. Added some comments and used better variable
names. Included are some lint warning fixes and style conformity changes.
commit
4b5e255dff699f59a5ced5186c4e4558b09a4003
Author: Russell Valentine <russ@coldstonelabs.org>
Date: Wed Jan 18 14:33:13 2012 -0600
Actual dashedLine coordinates checked now. Oops.
commit
a5930c675465e6566854d3b6e2b9d6fa606ce91c
Author: Russell Valentine <russ@coldstonelabs.org>
Date: Wed Jan 18 14:25:51 2012 -0600
per series stroke pattern support.
Dan Vanderkam [Thu, 26 Jan 2012 19:28:28 +0000 (14:28 -0500)]
a few more users
timeu [Thu, 26 Jan 2012 18:53:04 +0000 (13:53 -0500)]
Fix for issues 236 & 270 from timeu.
Issue 236: Highlight callback will fail if the first data series has visibility=false
Issue 270: Remove onResize event handler in destroy() function
Dan Vanderkam [Thu, 26 Jan 2012 18:35:07 +0000 (13:35 -0500)]
Fix for issue 267, from Paul Felix
Robert Konigsberg [Wed, 25 Jan 2012 16:23:23 +0000 (11:23 -0500)]
Apply firefox fix to the gallery. (We should remove the test altogether someday. :))
Robert Konigsberg [Wed, 25 Jan 2012 16:21:03 +0000 (08:21 -0800)]
Merge pull request #117 from jllodra/master
tests/interaction.js: fix for firefox
Josep Llodrà [Wed, 25 Jan 2012 10:48:23 +0000 (11:48 +0100)]
event.offsetX and Y fixed for Firefox in interaction.js
Dan Vanderkam [Mon, 23 Jan 2012 20:20:34 +0000 (15:20 -0500)]
Add 10gen MMS to Usage Gallery
Dan Vanderkam [Mon, 23 Jan 2012 19:43:44 +0000 (14:43 -0500)]
Add Eutelsat & NASA to Usage Gallery
Dan Vanderkam [Mon, 23 Jan 2012 18:16:50 +0000 (13:16 -0500)]
Expose range selector interaction model publicly (removes need for pull request 101).
Dan Vanderkam [Mon, 23 Jan 2012 18:12:25 +0000 (10:12 -0800)]
Merge pull request #103 from mattmiller/master
Allows unescaped HTML in X and Y labels and values.
Dan Vanderkam [Fri, 20 Jan 2012 20:49:05 +0000 (15:49 -0500)]
Merge branch 'master' of github.com:danvk/dygraphs
mbghsource [Fri, 20 Jan 2012 20:48:23 +0000 (15:48 -0500)]
Fix issue 264 - non-alpha chars in GViz annotation labels.
Robert Konigsberg [Thu, 19 Jan 2012 04:31:58 +0000 (23:31 -0500)]
Remove memory leaks from dygraph-many-points-benchmark.
Russell Valentine [Wed, 18 Jan 2012 22:16:04 +0000 (17:16 -0500)]
Per y-axis valueRange support.
Robert Konigsberg [Tue, 17 Jan 2012 04:18:31 +0000 (20:18 -0800)]
Merge pull request #112 from kberg/master
plotter demo fix
Robert Konigsberg [Tue, 17 Jan 2012 04:16:16 +0000 (23:16 -0500)]
Plotter demo bugfix.
Robert Konigsberg [Tue, 17 Jan 2012 02:56:20 +0000 (18:56 -0800)]
Merge pull request #111 from kberg/master
OK, this is the last one.
Robert Konigsberg [Tue, 17 Jan 2012 02:54:06 +0000 (21:54 -0500)]
tiny
Robert Konigsberg [Tue, 17 Jan 2012 02:53:26 +0000 (21:53 -0500)]
Style tweaks
Robert Konigsberg [Tue, 17 Jan 2012 01:13:35 +0000 (17:13 -0800)]
Merge pull request #110 from kberg/master
last tweaks before announcing.
Robert Konigsberg [Tue, 17 Jan 2012 01:10:51 +0000 (20:10 -0500)]
stuff. i'm tired.
Robert Konigsberg [Tue, 17 Jan 2012 01:10:22 +0000 (20:10 -0500)]
Make text area size configurable in pixels.
Robert Konigsberg [Tue, 17 Jan 2012 00:56:52 +0000 (16:56 -0800)]
Merge pull request #109 from kberg/master
More gallery cleanup.
Robert Konigsberg [Tue, 17 Jan 2012 00:51:22 +0000 (19:51 -0500)]
Show introductory text.