From: Dan Vanderkam <danvdk@gmail.com>
Date: Sun, 17 Feb 2013 04:36:15 +0000 (-0500)
Subject: Fix & regression test for issue 363: Calling setSelection() after an updateOptions... 
X-Git-Tag: v1.0.0~68
X-Git-Url: https://adrianiainlam.tk/git/?a=commitdiff_plain;h=fa11f4e40237910cd7c5a6854943cc39ebc049f8;p=dygraphs.git

Fix & regression test for issue 363: Calling setSelection() after an updateOptions may have no effect
---

diff --git a/auto_tests/tests/stacked.js b/auto_tests/tests/stacked.js
index de41733..d9aadbf 100644
--- a/auto_tests/tests/stacked.js
+++ b/auto_tests/tests/stacked.js
@@ -86,8 +86,9 @@ stackedTestCase.prototype.testSelectionValues = function() {
       strokeWidth: 10
     }
   });
-  // NOTE: calling g.setSelection(0) here makes the test fail, due to an
-  // unrelated bug.
+  g.setSelection(0);
+  assertEquals("0: Y1: 1 Y2: 1", Util.getLegend());
+
   g.setSelection(1);
   assertEquals("1: Y1: 1 Y2: 1", Util.getLegend());
 
diff --git a/dygraph.js b/dygraph.js
index 3dfc326..af1ca65 100644
--- a/dygraph.js
+++ b/dygraph.js
@@ -2472,6 +2472,7 @@ Dygraph.prototype.renderGraph_ = function(is_initial_draw) {
   this.cascadeEvents_('willDrawChart', e);
   this.plotter_.render();
   this.cascadeEvents_('didDrawChart', e);
+  this.lastRow_ = -1;  // because plugins/legend.js clears the legend
 
   // TODO(danvk): is this a performance bottleneck when panning?
   // The interaction canvas should already be empty in that situation.