From: Dan Vanderkam <danvdk@gmail.com>
Date: Mon, 15 Dec 2014 21:54:59 +0000 (-0500)
Subject: Rename syncRange --> range, cleanup, document, test.
X-Git-Tag: v2.0.0~77
X-Git-Url: https://adrianiainlam.tk/git/?a=commitdiff_plain;h=b94ba4b52e227816448775cce9687f33a80cfe9a;p=dygraphs.git

Rename syncRange --> range, cleanup, document, test.
---

diff --git a/extras/synchronizer.js b/extras/synchronizer.js
index 228390e..ca05a2b 100644
--- a/extras/synchronizer.js
+++ b/extras/synchronizer.js
@@ -20,13 +20,16 @@
  *
  * The default is to synchronize both of these.
  *
- * Instead of passing one Dygraph objet as each parameter, you may also pass an
+ * Instead of passing one Dygraph object as each parameter, you may also pass an
  * array of dygraphs:
  *
  *   var sync = Dygraph.synchronize([g1, g2, g3], {
  *      selection: false,
  *      zoom: true
  *   });
+ *
+ * You may also set `range: false` if you wish to only sync the x-axis.
+ * The `range` option has no effect unless `zoom` is true (the default).
  */
 (function() {
 /* global Dygraph:false */
@@ -37,11 +40,11 @@ Dygraph.synchronize = function(/* dygraphs..., opts */) {
     throw 'Invalid invocation of Dygraph.synchronize(). Need >= 1 argument.';
   }
 
-  var OPTIONS = ['selection', 'zoom', 'syncRange'];
+  var OPTIONS = ['selection', 'zoom', 'range'];
   var opts = {
     selection: true,
     zoom: true,
-    syncRange: true
+    range: true
   };
   var dygraphs = [];
 
@@ -94,12 +97,7 @@ Dygraph.synchronize = function(/* dygraphs..., opts */) {
 
   // Listen for draw, highlight, unhighlight callbacks.
   if (opts.zoom) {
-    if (opts.syncRange) {
-      attachZoomHandlers(dygraphs,true);
-    }
-    else {      
-      attachZoomHandlers(dygraphs,false);
-    }
+    attachZoomHandlers(dygraphs, opts);
   }
 
   if (opts.selection) {
@@ -128,7 +126,7 @@ Dygraph.synchronize = function(/* dygraphs..., opts */) {
 };
 
 // TODO: call any `drawCallback`s that were set before this.
-function attachZoomHandlers(gs,syncRange) {
+function attachZoomHandlers(gs, syncOpts) {
   var block = false;
   for (var i = 0; i < gs.length; i++) {
     var g = gs[i];
@@ -136,21 +134,14 @@ function attachZoomHandlers(gs,syncRange) {
       drawCallback: function(me, initial) {
         if (block || initial) return;
         block = true;
-        var range = me.xAxisRange();
-        var yrange = me.yAxisRange();
+        var opts = {
+          dateWindow: me.xAxisRange()
+        };
+        if (syncOpts.range) opts.valueRange = me.yAxisRange();
+
         for (var j = 0; j < gs.length; j++) {
           if (gs[j] == me) continue;
-          if (syncRange) {
-            gs[j].updateOptions( {
-              dateWindow: range,
-              valueRange: yrange
-            });
-          }
-          else {
-            gs[j].updateOptions( {
-              dateWindow: range
-            });
-          }
+          gs[j].updateOptions(opts);
         }
         block = false;
       }
diff --git a/tests/synchronize.html b/tests/synchronize.html
index 726f9e8..a98224d 100644
--- a/tests/synchronize.html
+++ b/tests/synchronize.html
@@ -37,6 +37,7 @@
       Synchronize what?
       <input type=checkbox id='chk-zoom' checked onChange='update()'><label for='chk-zoom'> Zoom</label>
       <input type=checkbox id='chk-selection' checked onChange='update()'><label for='chk-selection'> Selection</label>
+      <input type=checkbox id='chk-range' checked onChange='update()'><label for='chk-range'> Range (y-axis)</label>
     </p>
 
     <script type="text/javascript">
@@ -56,12 +57,16 @@
       var sync = Dygraph.synchronize(gs);
       
       function update() {
-        var zoom = document.getElementById('chk-zoom').checked;
-        var selection = document.getElementById('chk-selection').checked;
+        var zoom = document.getElementById('chk-zoom').checked,
+            selection = document.getElementById('chk-selection').checked,
+            syncRange = document.getElementById('chk-range').checked;
+        document.getElementById('chk-range').disabled = !zoom;
+
         sync.detach();
         sync = Dygraph.synchronize(gs, {
           zoom: zoom,
-          selection: selection
+          selection: selection,
+          range: syncRange
         });
       }
     </script>