From: Robert Konigsberg <konigsberg@google.com>
Date: Mon, 18 Jun 2012 19:26:20 +0000 (-0400)
Subject: Rewrite iterator.
X-Git-Tag: v1.0.0~238^2^2~3
X-Git-Url: https://adrianiainlam.tk/git/?a=commitdiff_plain;h=a26206cf90b131c7a7ef1a55322b1a60514fd213;p=dygraphs.git

Rewrite iterator.
---

diff --git a/dygraph-utils.js b/dygraph-utils.js
index 9d599f3..8cfd861 100644
--- a/dygraph-utils.js
+++ b/dygraph-utils.js
@@ -681,64 +681,68 @@ Dygraph.isAndroid = function() {
   return (/Android/).test(navigator.userAgent);
 };
 
+Dygraph.Iterator = function(array, start, length, predicate) {
+  start = start || 0;
+  length = length || array.length;
+  this.array_ = array;
+  this.predicate_ = predicate;
+  this.end_ = Math.min(array.length, start + length);
+  this.nextIdx_ = start - 1; // use -1 so initial call to advance works.
+  this.hasNext_ = true;
+  this.peek_ = null;
+  this.advance_();
+}
+
+Dygraph.Iterator.prototype.hasNext = function() {
+  return this.hasNext_;
+}
+
+Dygraph.Iterator.prototype.next = function() {
+  if (this.hasNext_) {
+    var obj = this.peek_;
+    this.advance_();
+    return obj;
+  }
+  return null;
+}
+
+Dygraph.Iterator.prototype.peek = function() {
+  return this.peek_;
+}
+
+Dygraph.Iterator.prototype.advance_ = function() {
+  var nextIdx = this.nextIdx_;
+  nextIdx++;
+  while(nextIdx < this.end_) {
+    if (!this.predicate_ || this.predicate_(this.array_, nextIdx)) {
+      this.peek_ = this.array_[nextIdx];
+      this.nextIdx_ = nextIdx;
+      return;
+    }
+    nextIdx++;
+  }
+  this.nextIdx_ = nextIdx;
+  this.hasNext_ = false;
+  this.peek_ = null;
+}
+
 /**
  * @private
  * Returns a new iterator over array, between indexes start and 
  * start + length, and only returns entries that pass the accept function
  *
  * @param array the array to iterate over.
- * @param start the first index to iterate over
+ * @param start the first index to iterate over, 0 if absent.
  * @param length the number of elements in the array to iterate over.
  * This, along with start, defines a slice of the array, and so length
  * doesn't imply the number of elements in the iterator when accept
- * doesn't always accept all values.
+ * doesn't always accept all values. array.length when absent.
  * @param predicate a function that takes parameters array and idx, which
  * returns true when the element should be returned. If omitted, all
  * elements are accepted.
  */
 Dygraph.createIterator = function(array, start, length, predicate) {
-  start = start || 0;
-  length = length || array.length;
-  var iter = new function() {
-    this.end_ = Math.min(array.length, start + length);
-    this.nextIdx_ = start - 1; // use -1 so initial call to advance works.
-    this.hasNext_ = true;
-    this.peek_ = null;
-    var self = this;
-
-    this.hasNext = function() {
-      return self.hasNext_;
-    }
-
-    this.next = function() {
-      if (self.hasNext_) {
-        var obj = self.peek_;
-        self.advance_();
-        return obj;
-      }
-      return null;
-    }
-    this.peek = function() {
-      return self.peek_;
-    }
-    this.advance_ = function() {
-      var nextIdx = self.nextIdx_;
-      nextIdx++;
-      while(nextIdx < self.end_) {
-        if (!predicate || predicate(array, nextIdx)) {
-          self.peek_ = array[nextIdx];
-          self.nextIdx_ = nextIdx;
-          return;
-        }
-        nextIdx++;
-      }
-      self.nextIdx_ = nextIdx;
-      self.hasNext_ = false;
-      self.peek_ = null;
-    }
-  };
-  iter.advance_();
-  return iter;
+  return new Dygraph.Iterator(array, start, length, predicate);
 };
 
 /**