From: Klaus Weidner <klausw@google.com>
Date: Tue, 29 Oct 2013 17:01:20 +0000 (-0700)
Subject: add regression test for NaN handling in errorbar mode.
X-Git-Tag: v1.1.0~70^2~2^2
X-Git-Url: https://adrianiainlam.tk/git/?a=commitdiff_plain;h=9e7974b84527785814b33c18bdeea28cbf1662a7;p=dygraphs.git

add regression test for NaN handling in errorbar mode.

See https://code.google.com/p/dygraphs/issues/detail?id=466 .

The reported issue was that NaN values were unexpectedly being
drawn as connected in customBar=true mode. This already
works correctly in current Dygraphs, I've converted the jsfiddle
demonstrating the issue to a regression test.
---

diff --git a/auto_tests/tests/connect_separated_points.js b/auto_tests/tests/connect_separated_points.js
index 95ef88e..bec5a52 100644
--- a/auto_tests/tests/connect_separated_points.js
+++ b/auto_tests/tests/connect_separated_points.js
@@ -406,3 +406,44 @@ ConnectSeparatedPointsTestCase.prototype.testConnectSeparatedPointsPerSeries = f
   });
   assertExpectedLinesDrawnPerSeries(htx, 4, 3, 3);
 }
+
+ConnectSeparatedPointsTestCase.prototype.testNaNErrorBars = function() {
+  var data = [
+    [0,[1,2,3]],
+    [1,[2,3,4]],
+    [2,[3,4,5]],
+    [3,[null,null,null]],
+    [4,[2,3,4]],
+    [5,[3,4,5]],
+    [6,[2,3,4]],
+    [7,[NaN,NaN,NaN]],
+    [8,[2,3,4]],
+    [9,[2,3,4]],
+    [10,[2,3,4]],
+    [11,[2,3,4]]
+  ];
+    
+  var opts = {
+    labels: ["x", "y"],
+    colors: ["#ff0000"],
+    customBars: true,
+    connectSeparatedPoints: true
+  };
+  
+  var graph = document.getElementById("graph");
+  var g = new Dygraph(graph, data, opts);
+  
+  htx = g.hidden_ctx_;
+
+  var attrs = {};  
+  
+  // Line should be drawn across the null gap.
+  CanvasAssertions.assertLineDrawn(htx, 
+	g.toDomCoords(data[2][0], data[2][1][1]),
+	g.toDomCoords(data[4][0], data[4][1][1]),
+        attrs);
+
+  // No line across the NaN gap, and a single line (not two)
+  // across the null gap.
+  assertEquals(8, CanvasAssertions.numLinesDrawn(htx, '#ff0000'));
+};