From: Adam Vartanian Date: Mon, 26 Dec 2011 04:30:08 +0000 (-0500) Subject: Extract the granularity-picking code of the date ticker into a new function. X-Git-Tag: v1.0.0~388 X-Git-Url: https://adrianiainlam.tk/git/?a=commitdiff_plain;h=7a1f1877f3979293d8f2c64c2b274b09b93d4135;p=dygraphs.git Extract the granularity-picking code of the date ticker into a new function. Extracting the granularity-selecting code into a new function, it would be useful for me to be able to call that in my own ticker. --- diff --git a/dygraph-tickers.js b/dygraph-tickers.js index 46fe765..64cf59f 100644 --- a/dygraph-tickers.js +++ b/dygraph-tickers.js @@ -199,15 +199,7 @@ Dygraph.numericTicks = function(a, b, pixels, opts, dygraph, vals) { Dygraph.dateTicker = function(a, b, pixels, opts, dygraph, vals) { - var pixels_per_tick = opts('pixelsPerLabel'); - var chosen = -1; - for (var i = 0; i < Dygraph.NUM_GRANULARITIES; i++) { - var num_ticks = Dygraph.numDateTicks(a, b, i); - if (pixels / num_ticks >= pixels_per_tick) { - chosen = i; - break; - } - } + var chosen = Dygraph.pickDateTickGranularity(a, b, pixels, opts); if (chosen >= 0) { return Dygraph.getDateAxis(a, b, chosen, opts, dygraph); @@ -277,6 +269,27 @@ Dygraph.PREFERRED_LOG_TICK_VALUES = function() { return vals; }(); +/** + * Determine the correct granularity of ticks on a date axis. + * + * @param {Number} a Left edge of the chart (ms) + * @param {Number} b Right edge of the chart (ms) + * @param {Number} pixels Size of the chart in the relevant dimension (width). + * @param {Function} opts Function mapping from option name -> value. + * @return {Number} The appropriate axis granularity for this chart. See the + * enumeration of possible values in dygraph-tickers.js. + */ +Dygraph.pickDateTickGranularity = function(a, b, pixels, opts) { + var pixels_per_tick = opts('pixelsPerLabel'); + for (var i = 0; i < Dygraph.NUM_GRANULARITIES; i++) { + var num_ticks = Dygraph.numDateTicks(a, b, i); + if (pixels / num_ticks >= pixels_per_tick) { + return i; + } + } + return -1; +}; + Dygraph.numDateTicks = function(start_time, end_time, granularity) { if (granularity < Dygraph.MONTHLY) { // Generate one tick mark for every fixed interval of time.