From: Dan Vanderkam <danvk@google.com>
Date: Tue, 10 Apr 2012 22:38:00 +0000 (-0400)
Subject: klaus comments on plugins
X-Git-Tag: v1.0.0~289
X-Git-Url: https://adrianiainlam.tk/git/?a=commitdiff_plain;h=5bd29cf4e97eabd68ab5361222653f6c32b7b229;p=dygraphs.git

klaus comments on plugins
---

diff --git a/dygraph.js b/dygraph.js
index 9a05677..e1cdd4e 100644
--- a/dygraph.js
+++ b/dygraph.js
@@ -477,7 +477,7 @@ Dygraph.prototype.cascadeEvents_ = function(name, extra_props) {
     },
     propagationStopped: false,
     stopPropagation: function() {
-      propagationStopped = true;
+      e.propagationStopped = true;
     }
   };
   Dygraph.update(e, extra_props);
diff --git a/plugins/base.js b/plugins/base.js
index 5ae917d..518a620 100644
--- a/plugins/base.js
+++ b/plugins/base.js
@@ -1,2 +1,4 @@
 // Namespace for plugins.
 Dygraph.Plugins = {};
+
+// TODO(danvk): move this into the top-level directory. Only plugins here.
diff --git a/plugins/install.js b/plugins/install.js
index 14aaefa..a7d8e6a 100644
--- a/plugins/install.js
+++ b/plugins/install.js
@@ -1,3 +1,4 @@
+// TODO(danvk): move this into the top-level directory. Only plugins here.
 Dygraph.PLUGINS.push(
   Dygraph.Plugins.Legend
 );