From: Robert Konigsberg <konigsberg@google.com>
Date: Sun, 18 Nov 2012 16:18:09 +0000 (-0500)
Subject: Dump Dygraph.seriesToAxisMap, move it into DygraphOptions. Add API to support it.
X-Git-Tag: v1.0.0~157^2~3^2~3
X-Git-Url: https://adrianiainlam.tk/git/?a=commitdiff_plain;h=16f00742bcc437c9acb34507d41600d976fd79d9;p=dygraphs.git

Dump Dygraph.seriesToAxisMap, move it into DygraphOptions. Add API to support it.
---

diff --git a/dygraph-options.js b/dygraph-options.js
index c15c684..0f65f39 100644
--- a/dygraph-options.js
+++ b/dygraph-options.js
@@ -11,7 +11,7 @@
  * dygraph_ - the graph.
  * global_ - global attributes (common among all graphs, AIUI)
  * user_ - attributes set by the user
- * axes_ - array of axis index to axis-specific options.
+ * axes_ - array of axis index to { series : [ series names ] , options : { axis-specific options. }
  * series_ - { seriesName -> { idx, yAxis, options }
  * labels_ - used as mapping from index to series name.
  */
@@ -46,7 +46,7 @@ var DygraphOptions = function(dygraph) {
 DygraphOptions.prototype.reparseSeries = function() {
   this.labels = this.find("labels").slice(1);
 
-  this.axes_ = [ {} ]; // Always one axis at least.
+  this.axes_ = [ { series : [], options : {}} ]; // Always one axis at least.
   this.series_ = {};
 
   var axisId = 0; // 0-offset; there's always one.
@@ -60,8 +60,14 @@ DygraphOptions.prototype.reparseSeries = function() {
     var axis = optionsForSeries["axis"];
     if (typeof(axis) == 'object') {
       yAxis = ++axisId;
-      this.axes_[yAxis] = axis;
+      this.axes_[yAxis] = { series : [ seriesName ], options : axis };
     }
+
+    // Associate series without axis options with axis 0.
+    if (!axis) { // undefined
+      this.axes_[0].series.push(seriesName);
+    }
+
     this.series_[seriesName] = { idx: idx, yAxis: yAxis, options : optionsForSeries };
   }
 
@@ -78,7 +84,9 @@ DygraphOptions.prototype.reparseSeries = function() {
                    "series " + axis + ", which does not define its own axis.");
         return null;
       }
-      this.series_[seriesName].yAxis = this.series_[axis].yAxis;
+      var yAxis = this.series_[axis].yAxis;
+      this.series_[seriesName].yAxis = yAxis;
+      this.axes_[yAxis].series.push(seriesName);
     }
   }
 
@@ -88,12 +96,12 @@ DygraphOptions.prototype.reparseSeries = function() {
     var axis_opts = this.user_.axes;
 
     if (axis_opts.hasOwnProperty("y")) {
-      Dygraph.update(this.axes_[0], axis_opts.y);
+      Dygraph.update(this.axes_[0].options, axis_opts.y);
     }
 
     if (axis_opts.hasOwnProperty("y2")) {
-      this.axes_[1] = this.axes_[1] || {};
-      Dygraph.update(this.axes_[1], axis_opts.y2);
+      this.axes_[1] = this.axes_[1] || {}; // FIX
+      Dygraph.update(this.axes_[1].options, axis_opts.y2);
     }
   }
 };
@@ -111,7 +119,7 @@ DygraphOptions.prototype.find = function(name) {
 DygraphOptions.prototype.findForAxis = function(name, axis) {
   var axisIdx = (axis == "y2" || axis == "y2" || axis == 1) ? 1 : 0;
 
-  var axisOptions = this.axes_[axisIdx];
+  var axisOptions = this.axes_[axisIdx].options;
   if (axisOptions.hasOwnProperty(name)) {
     return axisOptions[name];
   }
@@ -148,3 +156,24 @@ DygraphOptions.prototype.findForSeries = function(name, series) {
 DygraphOptions.prototype.numAxes = function() {
   return this.axes_.length;
 }
+
+/**
+ * Return the y-axis for a given series, specified by name.
+ */
+DygraphOptions.prototype.axisForSeries = function(seriesName) {
+  return this.series_[seriesName].yAxis;
+}
+
+/**
+ * Returns the options for the specified axis.
+ */
+DygraphOptions.prototype.axisOptions = function(yAxis) {
+  return this.axes_[yAxis].options;
+}
+
+/**
+ * Return the series associated with an axis.
+ */
+DygraphOptions.prototype.seriesForAxis = function(yAxis) {
+  return this.axes_[yAxis].series;
+}
diff --git a/dygraph.js b/dygraph.js
index df12101..42761cf 100644
--- a/dygraph.js
+++ b/dygraph.js
@@ -1132,7 +1132,7 @@ Dygraph.prototype.getPropertiesForSeries = function(series_name) {
     column: idx,
     visible: this.visibility()[idx - 1],
     color: this.colorsMap_[series_name],
-    axis: 1 + this.seriesToAxisMap_[series_name]
+    axis: 1 + this.attributes_.axisForSeries(series_name)
   };
 };
 
@@ -2407,9 +2407,8 @@ Dygraph.prototype.renderGraph_ = function(is_initial_draw) {
  * currently being displayed. This includes things like the number of axes and
  * the style of the axes. It does not include the range of each axis and its
  * tick marks.
- * This fills in this.axes_ and this.seriesToAxisMap_.
+ * This fills in this.axes_.
  * axes_ = [ { options } ]
- * seriesToAxisMap_ = { seriesName: 0, seriesName2: 1, ... }
  *   indices are into the axes_ array.
  */
 Dygraph.prototype.computeYAxes_ = function() {
@@ -2424,7 +2423,6 @@ Dygraph.prototype.computeYAxes_ = function() {
   }
 
   this.axes_ = [{ yAxisId : 0, g : this }];  // always have at least one y-axis.
-  this.seriesToAxisMap_ = {};
 
   // Get a list of series names.
   var labels = this.attr_("labels");
@@ -2456,7 +2454,6 @@ Dygraph.prototype.computeYAxes_ = function() {
     if (!series.hasOwnProperty(seriesName)) continue;
     axis = this.attr_("axis", seriesName);
     if (axis === null) {
-      this.seriesToAxisMap_[seriesName] = 0;
       continue;
     }
     if (typeof(axis) == 'object') {
@@ -2469,23 +2466,6 @@ Dygraph.prototype.computeYAxes_ = function() {
       opts.g = this;
       Dygraph.update(opts, axis);
       this.axes_.push(opts);
-      this.seriesToAxisMap_[seriesName] = yAxisId;
-    }
-  }
-
-  // Go through one more time and assign series to an axis defined by another
-  // series, e.g. { 'Y1: { axis: {} }, 'Y2': { axis: 'Y1' } }
-  for (seriesName in series) {
-    if (!series.hasOwnProperty(seriesName)) continue;
-    axis = this.attr_("axis", seriesName);
-    if (typeof(axis) == 'string') {
-      if (!this.seriesToAxisMap_.hasOwnProperty(axis)) {
-        this.error("Series " + seriesName + " wants to share a y-axis with " +
-                   "series " + axis + ", which does not define its own axis.");
-        return null;
-      }
-      var idx = this.seriesToAxisMap_[axis];
-      this.seriesToAxisMap_[seriesName] = idx;
     }
   }
 
@@ -2518,13 +2498,7 @@ Dygraph.prototype.computeYAxes_ = function() {
  * @return {Number} the number of axes.
  */
 Dygraph.prototype.numAxes = function() {
-  var last_axis = 0;
-  for (var series in this.seriesToAxisMap_) {
-    if (!this.seriesToAxisMap_.hasOwnProperty(series)) continue;
-    var idx = this.seriesToAxisMap_[series];
-    if (idx > last_axis) last_axis = idx;
-  }
-  return 1 + last_axis;
+  return this.attributes_.numAxes();
 };
 
 /**
@@ -2536,7 +2510,7 @@ Dygraph.prototype.numAxes = function() {
  */
 Dygraph.prototype.axisPropertiesForSeries = function(series) {
   // TODO(danvk): handle errors.
-  return this.axes_[this.seriesToAxisMap_[series]];
+  return this.axes_[this.attributes_.axisForSeries(series)];
 };
 
 /**
@@ -2547,16 +2521,15 @@ Dygraph.prototype.axisPropertiesForSeries = function(series) {
  */
 Dygraph.prototype.computeYAxisRanges_ = function(extremes) {
   // Build a map from axis number -> [list of series names]
-  var seriesForAxis = [], series;
-  for (series in this.seriesToAxisMap_) {
-    if (!this.seriesToAxisMap_.hasOwnProperty(series)) continue;
-    var idx = this.seriesToAxisMap_[series];
-    while (seriesForAxis.length <= idx) seriesForAxis.push([]);
-    seriesForAxis[idx].push(series);
+  var seriesForAxis = [];
+  var series;
+  var numAxes = this.attributes_.numAxes();
+  for (var yAxis = 0; yAxis < numAxes; yAxis++) {
+    seriesForAxis[yAxis] = this.attributes_.seriesForAxis(yAxis);
   }
 
   // Compute extreme values, a span and tick marks for each axis.
-  for (var i = 0; i < this.axes_.length; i++) {
+  for (var i = 0; i < numAxes; i++) {
     var axis = this.axes_[i];
 
     if (!seriesForAxis[i]) {