From: Dan Vanderkam <dan@dygraphs.com>
Date: Wed, 25 Jul 2012 21:42:18 +0000 (-0400)
Subject: restore copy & fix zooming bug with error bars
X-Git-Tag: v1.0.0~212
X-Git-Url: https://adrianiainlam.tk/git/?a=commitdiff_plain;h=16879a6b4e206378922de67c50f67a38193d5f53;p=dygraphs.git

restore copy & fix zooming bug with error bars
---

diff --git a/dygraph.js b/dygraph.js
index 3a60180..2fd2c05 100644
--- a/dygraph.js
+++ b/dygraph.js
@@ -2172,11 +2172,13 @@ Dygraph.prototype.gatherDatasets_ = function(rolledSeries, dateWindow) {
   for (i = num_series; i >= 1; i--) {
     if (!this.visibility()[i - 1]) continue;
 
-    // TODO(danvk): is this copy really necessary?
-    var series = rolledSeries[i];  // [];
-    // for (j = 0; j < rolledSeries[i].length; j++) {
-    //   series.push(rolledSeries[i][j]);
-    // }
+    // Note: this copy _is_ necessary at the moment.
+    // If you remove it, it breaks zooming with error bars on.
+    // TODO(danvk): investigate further & write a test for this.
+    var series = [];
+    for (j = 0; j < rolledSeries[i].length; j++) {
+      series.push(rolledSeries[i][j]);
+    }
 
     // Prune down to the desired range, if necessary (for zooming)
     // Because there can be lines going to points outside of the visible area,