Fix & regression test for issue 363: Calling setSelection() after an updateOptions...
authorDan Vanderkam <danvdk@gmail.com>
Sun, 17 Feb 2013 04:36:15 +0000 (23:36 -0500)
committerDan Vanderkam <danvdk@gmail.com>
Sun, 17 Feb 2013 04:36:15 +0000 (23:36 -0500)
auto_tests/tests/stacked.js
dygraph.js

index de41733..d9aadbf 100644 (file)
@@ -86,8 +86,9 @@ stackedTestCase.prototype.testSelectionValues = function() {
       strokeWidth: 10
     }
   });
-  // NOTE: calling g.setSelection(0) here makes the test fail, due to an
-  // unrelated bug.
+  g.setSelection(0);
+  assertEquals("0: Y1: 1 Y2: 1", Util.getLegend());
+
   g.setSelection(1);
   assertEquals("1: Y1: 1 Y2: 1", Util.getLegend());
 
index 3dfc326..af1ca65 100644 (file)
@@ -2472,6 +2472,7 @@ Dygraph.prototype.renderGraph_ = function(is_initial_draw) {
   this.cascadeEvents_('willDrawChart', e);
   this.plotter_.render();
   this.cascadeEvents_('didDrawChart', e);
+  this.lastRow_ = -1;  // because plugins/legend.js clears the legend
 
   // TODO(danvk): is this a performance bottleneck when panning?
   // The interaction canvas should already be empty in that situation.