Merge pull request #164 from wimme/patch-3
authorDan Vanderkam <danvdk@gmail.com>
Wed, 15 Aug 2012 17:41:32 +0000 (10:41 -0700)
committerDan Vanderkam <danvdk@gmail.com>
Wed, 15 Aug 2012 17:41:32 +0000 (10:41 -0700)
Stepplot and errorbars sync fix

dygraph-utils.js
tests/dygraph-many-points-benchmark.html

index e942f0c..dd8c620 100644 (file)
@@ -177,7 +177,12 @@ Dygraph.removeEvent = function addEvent(elem, type, fn) {
   if (elem.removeEventListener) {
     elem.removeEventListener(type, fn, false);
   } else {
-    elem.detachEvent('on'+type, elem[type+fn]);
+    try {
+      elem.detachEvent('on'+type, elem[type+fn]);
+    } catch(e) {
+      // We only detach event listeners on a "best effort" basis in IE. See:
+      // http://stackoverflow.com/questions/2553632/detachevent-not-working-with-named-inline-functions
+    }
     elem[type+fn] = null;
   }
 };
index 09c89a6..17dadcd 100644 (file)
         series: 1,
         rollPeriod: 1,
         repetitions: 1,
-        type: 'sine',
+        type: 'sine'
       };
 
       // Parse the URL for parameters. Use it to override the values hash.