Closurize rgbcolor.js
authorRobert Konigsberg <konigsberg@google.com>
Sat, 30 Mar 2013 02:18:55 +0000 (22:18 -0400)
committerRobert Konigsberg <konigsberg@google.com>
Sat, 30 Mar 2013 02:19:11 +0000 (22:19 -0400)
closure-todo.txt
rgbcolor/rgbcolor.js

index c9d42b7..9852856 100644 (file)
@@ -30,6 +30,9 @@ Plugins:
 - plugins/grid.js
 - plugins/legend.js
 
+Others:
+x rgbcolor/rgbcolor.js
+
 Here's a command that can be used to build dygraphs using the closure
 compiler:
 java -jar ../../closure-compiler-read-only/build/compiler.jar --js=dygraph-utils.js --js=dashed-canvas.js --js=dygraph-options-reference.js --js=dygraph-tickers.js --js=dygraph-gviz.js --js_output_file=/tmp/out.js --compilation_level ADVANCED_OPTIMIZATIONS --warning_level VERBOSE --externs dygraph-externs.js
index 5a88244..bcdf94c 100644 (file)
@@ -9,12 +9,21 @@
  *   http://www.w3.org/TR/DOM-Level-2-Style/css.html#CSS-RGBColor
  * so renamed to "RGBColorParser"
  *
+ * Modifications by konigsberg:
+ * Make Closure-compatible.
+ *
  * @author Stoyan Stefanov <sstoo@gmail.com>
  * @link   http://www.phpied.com/rgb-color-parser-in-javascript/
  * @license Use it if you like it
  */
 "use strict";
 
+/**
+ * Create a new instance.
+ *
+ * @param {string} color_string the string to be parsed.
+ * @constructor
+ */
 function RGBColorParser(color_string)
 {
     this.ok = false;
@@ -188,9 +197,9 @@ function RGBColorParser(color_string)
             example: ['rgb(123, 234, 45)', 'rgb(255,234,245)'],
             process: function (bits){
                 return [
-                    parseInt(bits[1]),
-                    parseInt(bits[2]),
-                    parseInt(bits[3])
+                    parseInt(bits[1], 10),
+                    parseInt(bits[2], 10),
+                    parseInt(bits[3], 10)
                 ];
             }
         },