X-Git-Url: https://adrianiainlam.tk/git/?a=blobdiff_plain;f=plugins%2Flegend.js;h=85424c6d47a414dc8ffca22f0f5189d541743d7b;hb=a353dfe3e96cde2e0bc77ebd7ebeb9bd7b9371d6;hp=68a676254ff1a12c6a1d834c06c4f102bfab4024;hpb=41da6a866e2c62655519ece637543aaa4b764c40;p=dygraphs.git diff --git a/plugins/legend.js b/plugins/legend.js index 68a6762..85424c6 100644 --- a/plugins/legend.js +++ b/plugins/legend.js @@ -94,13 +94,14 @@ legend.prototype.activate = function(g) { } this.legend_div_ = div; + this.one_em_width_ = 10; // just a guess, will be updated. return { select: this.select, deselect: this.deselect, // TODO(danvk): rethink the name "predraw" before we commit to it in any API. predraw: this.predraw, - drawChart: this.drawChart + didDrawChart: this.didDrawChart }; }; @@ -118,21 +119,20 @@ legend.prototype.select = function(e) { var xValue = e.selectedX; var points = e.selectedPoints; - // Have to do this every time, since styles might have changed. - // TODO(danvk): this is not necessary; dashes never used in this case. - var oneEmWidth = calculateEmWidthInDiv(this.legend_div_); - - var html = generateLegendHTML(e.dygraph, xValue, points, oneEmWidth); + var html = generateLegendHTML(e.dygraph, xValue, points, this.one_em_width_); this.legend_div_.innerHTML = html; }; legend.prototype.deselect = function(e) { + // Have to do this every time, since styles might have changed. var oneEmWidth = calculateEmWidthInDiv(this.legend_div_); + this.one_em_width_ = oneEmWidth; + var html = generateLegendHTML(e.dygraph, undefined, undefined, oneEmWidth); this.legend_div_.innerHTML = html; }; -legend.prototype.drawChart = function(e) { +legend.prototype.didDrawChart = function(e) { this.deselect(e); } @@ -150,6 +150,7 @@ legend.prototype.predraw = function(e) { if (!this.is_generated_div_) return; // TODO(danvk): only use real APIs for this. + e.dygraph.graphDiv.appendChild(this.legend_div_); var area = e.dygraph.plotter_.area; this.legend_div_.style.left = area.x + area.w - e.dygraph.getOption("labelsDivWidth") - 1 + "px"; this.legend_div_.style.top = area.y + "px"; @@ -208,7 +209,10 @@ var generateLegendHTML = function(g, x, sel_points, oneEmWidth) { // TODO(danvk): remove this use of a private API var xOptView = g.optionsViewForAxis_('x'); var xvf = xOptView('valueFormatter'); - html = xvf(x, xOptView, labels[0], g) + ":"; + html = xvf(x, xOptView, labels[0], g); + if(html !== '') { + html += ':'; + } var yOptViews = []; var num_axes = g.numAxes();