X-Git-Url: https://adrianiainlam.tk/git/?a=blobdiff_plain;f=plugins%2Flegend.js;h=79f758d6eb6464833cf5b7d858a46bfe57fb4bbb;hb=3bdeeb9b9d123e9e45159a6801b6e7fe74f08690;hp=85424c6d47a414dc8ffca22f0f5189d541743d7b;hpb=c3b1d17da4b5d6badbeeb2cf25cb8f8061e1ccd5;p=dygraphs.git diff --git a/plugins/legend.js b/plugins/legend.js index 85424c6..79f758d 100644 --- a/plugins/legend.js +++ b/plugins/legend.js @@ -5,7 +5,6 @@ */ Dygraph.Plugins.Legend = (function() { - /* Current bits of jankiness: @@ -17,6 +16,8 @@ Current bits of jankiness: */ +/*jshint globalstrict: true */ +/*global Dygraph:false */ "use strict"; @@ -35,6 +36,9 @@ legend.prototype.toString = function() { return "Legend Plugin"; }; +// (defined below) +var generateLegendHTML, generateLegendDashHTML; + /** * This is called during the dygraph constructor, after options have been set * but before the data is available. @@ -134,7 +138,7 @@ legend.prototype.deselect = function(e) { legend.prototype.didDrawChart = function(e) { this.deselect(e); -} +}; // Right edge should be flush with the right edge of the charting area (which // may not be the same as the right edge of the div, if we have two y-axes. @@ -152,8 +156,10 @@ legend.prototype.predraw = function(e) { // TODO(danvk): only use real APIs for this. e.dygraph.graphDiv.appendChild(this.legend_div_); var area = e.dygraph.plotter_.area; - this.legend_div_.style.left = area.x + area.w - e.dygraph.getOption("labelsDivWidth") - 1 + "px"; + var labelsDivWidth = e.dygraph.getOption("labelsDivWidth"); + this.legend_div_.style.left = area.x + area.w - labelsDivWidth - 1 + "px"; this.legend_div_.style.top = area.y + "px"; + this.legend_div_.style.width = labelsDivWidth + "px"; }; /** @@ -176,7 +182,7 @@ legend.prototype.destroy = function() { * relevant when displaying a legend with no selection (i.e. {legend: * 'always'}) and with dashed lines. */ -var generateLegendHTML = function(g, x, sel_points, oneEmWidth) { +generateLegendHTML = function(g, x, sel_points, oneEmWidth) { // TODO(danvk): deprecate this option in place of {legend: 'never'} if (g.getOption('showLabelsOnHighlight') !== true) return ''; @@ -210,8 +216,8 @@ var generateLegendHTML = function(g, x, sel_points, oneEmWidth) { var xOptView = g.optionsViewForAxis_('x'); var xvf = xOptView('valueFormatter'); html = xvf(x, xOptView, labels[0], g); - if(html !== '') { - html += ':'; + if (html !== '') { + html += ':'; } var yOptViews = []; @@ -255,7 +261,7 @@ var generateLegendHTML = function(g, x, sel_points, oneEmWidth) { * @param oneEmWidth The width in pixels of 1em in the legend. * @private */ -var generateLegendDashHTML = function(strokePattern, color, oneEmWidth) { +generateLegendDashHTML = function(strokePattern, color, oneEmWidth) { // IE 7,8 fail at these divs, so they get boring legend, have not tested 9. var isIE = (/MSIE/.test(navigator.userAgent) && !window.opera); if (isIE) return "—";