X-Git-Url: https://adrianiainlam.tk/git/?a=blobdiff_plain;f=plugins%2Flegend.js;h=7406f82a950f3c7cf7e516786591123f9400eee9;hb=bc262c4039fb9fd8e22a520bd83b5a0c646800ec;hp=c124c38fad073e89d31ac4efe796260b52e16700;hpb=f34f95d1f2fe3adcc0bbe578368740afba513d9f;p=dygraphs.git diff --git a/plugins/legend.js b/plugins/legend.js index c124c38..7406f82 100644 --- a/plugins/legend.js +++ b/plugins/legend.js @@ -3,6 +3,7 @@ * Copyright 2012 Dan Vanderkam (danvdk@gmail.com) * MIT-licensed (http://opensource.org/licenses/MIT) */ +/*global Dygraph:false */ Dygraph.Plugins.Legend = (function() { /* @@ -16,6 +17,8 @@ Current bits of jankiness: */ +/*jshint globalstrict: true */ +/*global Dygraph:false */ "use strict"; @@ -34,6 +37,9 @@ legend.prototype.toString = function() { return "Legend Plugin"; }; +// (defined below) +var generateLegendHTML, generateLegendDashHTML; + /** * This is called during the dygraph constructor, after options have been set * but before the data is available. @@ -133,7 +139,7 @@ legend.prototype.deselect = function(e) { legend.prototype.didDrawChart = function(e) { this.deselect(e); -} +}; // Right edge should be flush with the right edge of the charting area (which // may not be the same as the right edge of the div, if we have two y-axes. @@ -151,8 +157,10 @@ legend.prototype.predraw = function(e) { // TODO(danvk): only use real APIs for this. e.dygraph.graphDiv.appendChild(this.legend_div_); var area = e.dygraph.plotter_.area; - this.legend_div_.style.left = area.x + area.w - e.dygraph.getOption("labelsDivWidth") - 1 + "px"; + var labelsDivWidth = e.dygraph.getOption("labelsDivWidth"); + this.legend_div_.style.left = area.x + area.w - labelsDivWidth - 1 + "px"; this.legend_div_.style.top = area.y + "px"; + this.legend_div_.style.width = labelsDivWidth + "px"; }; /** @@ -175,14 +183,14 @@ legend.prototype.destroy = function() { * relevant when displaying a legend with no selection (i.e. {legend: * 'always'}) and with dashed lines. */ -var generateLegendHTML = function(g, x, sel_points, oneEmWidth) { +generateLegendHTML = function(g, x, sel_points, oneEmWidth) { // TODO(danvk): deprecate this option in place of {legend: 'never'} if (g.getOption('showLabelsOnHighlight') !== true) return ''; // If no points are selected, we display a default legend. Traditionally, // this has been blank. But a better default would be a conventional legend, // which provides essential information for a non-interactive chart. - var html, sepLines, i, c, dash, strokePattern; + var html, sepLines, i, dash, strokePattern; var labels = g.getLabels(); if (typeof(x) === 'undefined') { @@ -209,8 +217,8 @@ var generateLegendHTML = function(g, x, sel_points, oneEmWidth) { var xOptView = g.optionsViewForAxis_('x'); var xvf = xOptView('valueFormatter'); html = xvf(x, xOptView, labels[0], g); - if(html !== '') { - html += ':'; + if (html !== '') { + html += ':'; } var yOptViews = []; @@ -237,7 +245,7 @@ var generateLegendHTML = function(g, x, sel_points, oneEmWidth) { // TODO(danvk): use a template string here and make it an attribute. html += "" + " " + - pt.name + ":" + yval + ""; + pt.name + ": " + yval + ""; } return html; }; @@ -254,7 +262,7 @@ var generateLegendHTML = function(g, x, sel_points, oneEmWidth) { * @param oneEmWidth The width in pixels of 1em in the legend. * @private */ -var generateLegendDashHTML = function(strokePattern, color, oneEmWidth) { +generateLegendDashHTML = function(strokePattern, color, oneEmWidth) { // IE 7,8 fail at these divs, so they get boring legend, have not tested 9. var isIE = (/MSIE/.test(navigator.userAgent) && !window.opera); if (isIE) return "—";