X-Git-Url: https://adrianiainlam.tk/git/?a=blobdiff_plain;f=plugins%2Fchart-labels.js;h=d6c10951d7cf6226f07a4a482def4583c8b257ca;hb=13f8b0472ff8e7336bdf56f69ff838a1f3e76162;hp=5a109df624a27205137431cf33f8595fd94668df;hpb=152b74a7864b92596a22a532ddfc535918049781;p=dygraphs.git diff --git a/plugins/chart-labels.js b/plugins/chart-labels.js index 5a109df..d6c1095 100644 --- a/plugins/chart-labels.js +++ b/plugins/chart-labels.js @@ -5,7 +5,10 @@ */ Dygraph.Plugins.ChartLabels = (function() { +"use strict"; + // TODO(danvk): move chart label options out of dygraphs and into the plugin. +// TODO(danvk): only tear down & rebuild the DIVs when it's necessary. var chart_labels = function() { this.title_div_ = null; @@ -22,7 +25,7 @@ chart_labels.prototype.activate = function(g) { return { layout: this.layout, // clearChart: this.clearChart, - drawChart: this.drawChart + didDrawChart: this.didDrawChart }; }; @@ -57,7 +60,7 @@ chart_labels.prototype.detachLabels_ = function() { var createRotatedDiv = function(g, box, axis, classes, html) { // TODO(danvk): is this outer div actually necessary? - div = document.createElement("div"); + var div = document.createElement("div"); div.style.position = 'absolute'; if (axis == 1) { // NOTE: this is cheating. Should be positioned relative to the box. @@ -99,7 +102,7 @@ var createRotatedDiv = function(g, box, axis, classes, html) { inner_div.style.top = '0px'; } - class_div = document.createElement("div"); + var class_div = document.createElement("div"); class_div.className = classes; class_div.innerHTML = html; @@ -168,7 +171,7 @@ chart_labels.prototype.layout = function(e) { } }; -chart_labels.prototype.drawChart = function(e) { +chart_labels.prototype.didDrawChart = function(e) { var g = e.dygraph; if (this.title_div_) { this.title_div_.children[0].innerHTML = g.getOption('title');