X-Git-Url: https://adrianiainlam.tk/git/?a=blobdiff_plain;f=plugins%2Fannotations.js;h=6a248949351ebcac23f6e7cbf2064d5c02379a70;hb=de9a8181064aa767e1c70c31a0027a0324cc33c6;hp=a3a13c345ef0e969d8dc40c9a900853ead759fe9;hpb=ee53deb9db465f5eea54e102ca755decef005496;p=dygraphs.git diff --git a/plugins/annotations.js b/plugins/annotations.js index a3a13c3..6a24894 100644 --- a/plugins/annotations.js +++ b/plugins/annotations.js @@ -4,12 +4,23 @@ * MIT-licensed (http://opensource.org/licenses/MIT) */ +/*global Dygraph:false */ + Dygraph.Plugins.Annotations = (function() { +"use strict"; + /** Current bits of jankiness: - Uses dygraph.layout_ to get the parsed annotations. - Uses dygraph.plotter_.area + +It would be nice if the plugin didn't require so much special support inside +the core dygraphs classes, but annotations involve quite a bit of parsing and +layout. + +TODO(danvk): cache DOM elements. + */ var annotations = function() { @@ -23,7 +34,7 @@ annotations.prototype.toString = function() { annotations.prototype.activate = function(g) { return { clearChart: this.clearChart, - drawChart: this.drawChart + didDrawChart: this.didDrawChart }; }; @@ -40,12 +51,12 @@ annotations.prototype.clearChart = function(e) { this.detachLabels(); }; -annotations.prototype.drawChart = function(e) { +annotations.prototype.didDrawChart = function(e) { var g = e.dygraph; // Early out in the (common) case of zero annotations. var points = g.layout_.annotated_points; - if (!points || points.length == 0) return; + if (!points || points.length === 0) return; var containerDiv = e.canvas.parentNode; var annotationStyle = {