X-Git-Url: https://adrianiainlam.tk/git/?a=blobdiff_plain;f=gallery%2Fnumber-format.js;h=cc3d22fcbe9f20141fcb221ae69956b224c16425;hb=6eef8c1b9ec7b247ee2b508032bd3ec957d0fb68;hp=6a20e3c57b29ca045a3d14c7fa265db13a615b17;hpb=c1f22b5a5d4ffbf25a75fc567232e65381c1938b;p=dygraphs.git

diff --git a/gallery/number-format.js b/gallery/number-format.js
index 6a20e3c..cc3d22f 100644
--- a/gallery/number-format.js
+++ b/gallery/number-format.js
@@ -1,3 +1,4 @@
+/*global Gallery,Dygraph,data */
 Gallery.register(
   'number-format',
   {
@@ -15,33 +16,33 @@ Gallery.register(
           "   variety of precisions.</p>" +
 
           "<p>Precision to use (1 to 21):" +
-          "  <input type='text' id='p_input' size='20' onchange='updateTable();'></p>" +
+          "  <input type='text' id='p_input' size='20'></p>" +
           "<p/>" +
           "<div id='content' style='font-family:Courier New,monospace'></div>";
     },
     run: function() {
       // Helper functions for generating an HTML table for holding the test
       // results.
-      createRow = function(columnType, columns) {
+      var createRow = function(columnType, columns) {
         var row = document.createElement('tr');
         for (var i = 0; i  < columns.length; i ++) {
           var th = document.createElement(columnType);
           var text = document.createTextNode(columns[i]);
           th.appendChild(text);
           row.appendChild(th);
-        };
+        }
         return row;
       };
 
-      createHeaderRow = function(columns) {
+      var createHeaderRow = function(columns) {
         return createRow('th', columns);
       };
 
-      createDataRow = function(columns) {
+      var createDataRow = function(columns) {
         return createRow('td', columns);
       };
 
-      createTable = function(headerColumns, dataColumnsList) {
+      var createTable = function(headerColumns, dataColumnsList) {
         var table = document.createElement('table');
         table.appendChild(createHeaderRow(headerColumns));
         for (var i = 0; i < dataColumnsList.length; i++) {
@@ -50,11 +51,11 @@ Gallery.register(
         return table;
       };
 
-      window.updateTable = function() {
+      var updateTable = function() {
         var headers = ['Dygraph.floatFormat()', 'toPrecision()',
                        'Dygraph.floatFormat()', 'toPrecision()'];
         var numbers = [];
-        var p = parseInt(document.getElementById('p_input').value);
+        var p = parseInt(document.getElementById('p_input').value, 10);
 
         for (var i = -10; i <= 10; i++) {
           var n = Math.pow(10, i);
@@ -66,7 +67,7 @@ Gallery.register(
 
         // Check exact values of 0.
         numbers.push([Dygraph.floatFormat(0.0, p),
-                      0.0.toPrecision(p)]);
+                      (0.0).toPrecision(p)]);
 
         var elem = document.getElementById('content');
         elem.innerHTML = '';
@@ -74,6 +75,7 @@ Gallery.register(
       };
 
       document.getElementById('p_input').value = '4';
+      document.getElementById('p_input').onchange = updateTable;
       updateTable();
     }
   });