X-Git-Url: https://adrianiainlam.tk/git/?a=blobdiff_plain;f=dygraph.js;h=3eaa18e7e412478834aa5deb76ea445ec043985e;hb=50360fd082e74dd47cdc95b96892fef7f2067ce9;hp=4b9b6f143187788bd3376baf132901ce97b3f78f;hpb=563c70ca88b5c168b6497955710f4312dfe4a6ac;p=dygraphs.git

diff --git a/dygraph.js b/dygraph.js
index 4b9b6f1..3eaa18e 100644
--- a/dygraph.js
+++ b/dygraph.js
@@ -92,6 +92,9 @@ Dygraph.DEFAULT_ATTRS = {
   labelsSeparateLines: false,
   labelsKMB: false,
   labelsKMG2: false,
+  showLabelsOnHighlight: true,
+
+  yValueFormatter: null,
 
   strokeWidth: 1.0,
 
@@ -144,8 +147,8 @@ Dygraph.prototype.__old_init__ = function(div, file, labels, attrs) {
  * Initializes the Dygraph. This creates a new DIV and constructs the PlotKit
  * and interaction <canvas> inside of it. See the constructor for details
  * on the parameters.
+ * @param {Element} div the Element to render the graph into.
  * @param {String | Function} file Source data
- * @param {Array.<String>} labels Names of the data series
  * @param {Object} attrs Miscellaneous other options
  * @private
  */
@@ -209,7 +212,7 @@ Dygraph.prototype.__init__ = function(div, file, attrs) {
 
   this.attrs_ = {};
   Dygraph.update(this.attrs_, Dygraph.DEFAULT_ATTRS);
-  
+
   this.boundaryIds_ = [];
 
   // Make a note of whether labels will be pulled from the CSV file.
@@ -561,7 +564,7 @@ Dygraph.prototype.getColors = function() {
 Dygraph.findPosX = function(obj) {
   var curleft = 0;
   if(obj.offsetParent)
-    while(1) 
+    while(1)
     {
       curleft += obj.offsetLeft;
       if(!obj.offsetParent)
@@ -897,9 +900,22 @@ Dygraph.prototype.mouseMove_ = function(event) {
 
   // Extract the points we've selected
   this.selPoints_ = [];
-  for (var i = 0; i < points.length; i++) {
+  var cumulative_sum = 0;  // used only if we have a stackedGraph.
+  var l = points.length;
+  for (var i = 0; i < l; i++) {
     if (points[i].xval == lastx) {
-      this.selPoints_.push(points[i]);
+      if (!this.attr_("stackedGraph")) {
+        this.selPoints_.push(points[i]);
+      } else {
+        // Clone the point, since we need to 'unstack' it below. Stacked points
+        // are in reverse order.
+        var p = {};
+        for (var k in points[l - i - 1]) {
+          p[k] = points[l - i -1][k];
+        }
+        p.yval -= cumulative_sum;
+        cumulative_sum += p.yval;
+      }
     }
   }
 
@@ -908,25 +924,13 @@ Dygraph.prototype.mouseMove_ = function(event) {
     if (px !== null && lastx != px) {
       // only fire if the selected point has changed.
       this.lastHighlightCallbackX = lastx;
-      if (!this.attr_("stackedGraph")) {
-        this.attr_("highlightCallback")(event, lastx, this.selPoints_);
-      } else {
-        // "unstack" the points.
-        var callbackPoints = this.selPoints_.map(
-            function(p) { return {xval: p.xval, yval: p.yval, name: p.name} });
-        var cumulative_sum = 0;
-        for (var j = callbackPoints.length - 1; j >= 0; j--) {
-          callbackPoints[j].yval -= cumulative_sum;
-          cumulative_sum += callbackPoints[j].yval;
-        }
-        this.attr_("highlightCallback")(event, lastx, callbackPoints);
-      }
+      this.attr_("highlightCallback")(event, lastx, this.selPoints_);
     }
   }
 
   // Save last x position for callbacks.
   this.lastx_ = lastx;
-  
+
   this.updateSelection_();
 };
 
@@ -951,19 +955,26 @@ Dygraph.prototype.updateSelection_ = function() {
 
     // Set the status message to indicate the selected point(s)
     var replace = this.attr_('xValueFormatter')(this.lastx_, this) + ":";
+    var fmtFunc = this.attr_('yValueFormatter');
     var clen = this.colors_.length;
-    for (var i = 0; i < this.selPoints_.length; i++) {
-      if (!isOK(this.selPoints_[i].canvasy)) continue;
-      if (this.attr_("labelsSeparateLines")) {
-        replace += "<br/>";
+
+    if (this.attr_('showLabelsOnHighlight')) {
+      // Set the status message to indicate the selected point(s)
+      for (var i = 0; i < this.selPoints_.length; i++) {
+        if (!isOK(this.selPoints_[i].canvasy)) continue;
+        if (this.attr_("labelsSeparateLines")) {
+          replace += "<br/>";
+        }
+        var point = this.selPoints_[i];
+        var c = new RGBColor(this.colors_[i%clen]);
+        var yval = fmtFunc ? fmtFunc(point.yval) : this.round_(point.yval, 2);
+        replace += " <b><font color='" + c.toHex() + "'>"
+                + point.name + "</font></b>:"
+                + yval;
       }
-      var point = this.selPoints_[i];
-      var c = new RGBColor(this.plotter_.colors[point.name]);
-      replace += " <b><font color='" + c.toHex() + "'>"
-              + point.name + "</font></b>:"
-              + this.round_(point.yval, 2);
+
+      this.attr_("labelsDiv").innerHTML = replace;
     }
-    this.attr_("labelsDiv").innerHTML = replace;
 
     // Draw colored circles over the center of each selected point
     ctx.save();
@@ -991,11 +1002,11 @@ Dygraph.prototype.setSelection = function(row) {
   // Extract the points we've selected
   this.selPoints_ = [];
   var pos = 0;
-  
+
   if (row !== false) {
     row = row-this.boundaryIds_[0][0];
   }
-  
+
   if (row !== false && row >= 0) {
     for (var i in this.layout_.datasets) {
       if (row < this.layout_.datasets[i].length) {
@@ -1004,7 +1015,7 @@ Dygraph.prototype.setSelection = function(row) {
       pos += this.layout_.datasets[i].length;
     }
   }
-  
+
   if (this.selPoints_.length) {
     this.lastx_ = this.selPoints_[0].xval;
     this.updateSelection_();
@@ -1048,7 +1059,7 @@ Dygraph.prototype.getSelection = function() {
   if (!this.selPoints_ || this.selPoints_.length < 1) {
     return -1;
   }
-  
+
   for (var row=0; row<this.layout_.points.length; row++ ) {
     if (this.layout_.points[row].x == this.selPoints_[0].x) {
       return row + this.boundaryIds_[0][0];
@@ -1359,7 +1370,7 @@ Dygraph.numericTicks = function(minV, maxV, self) {
       scale = base_scale * mults[j];
       low_val = Math.floor(minV / scale) * scale;
       high_val = Math.ceil(maxV / scale) * scale;
-      nTicks = (high_val - low_val) / scale;
+      nTicks = Math.abs(high_val - low_val) / scale;
       var spacing = self.height_ / nTicks;
       // wish I could break out of both loops at once...
       if (spacing > pixelsPerTick) break;
@@ -1381,6 +1392,9 @@ Dygraph.numericTicks = function(minV, maxV, self) {
     k_labels = [ "k", "M", "G", "T" ];
   }
 
+  // Allow reverse y-axis if it's explicitly requested.
+  if (low_val > high_val) scale *= -1;
+
   for (var i = 0; i < nTicks; i++) {
     var tickV = low_val + i * scale;
     var absTickV = Math.abs(tickV);
@@ -2149,7 +2163,7 @@ Dygraph.prototype.updateOptions = function(attrs) {
 
   // TODO(danvk): this doesn't match the constructor logic
   this.layout_.updateOptions({ 'errorBars': this.attr_("errorBars") });
-  if (attrs['file'] && attrs['file'] != this.file_) {
+  if (attrs['file']) {
     this.file_ = attrs['file'];
     this.start_();
   } else {
@@ -2262,8 +2276,7 @@ Dygraph.GVizChart.prototype.draw = function(data, options) {
 
 /**
  * Google charts compatible setSelection
- * Only row selection is supported, all points in the 
- * row will be highlighted
+ * Only row selection is supported, all points in the row will be highlighted
  * @param {Array} array of the selected cells
  * @public
  */
@@ -2282,11 +2295,11 @@ Dygraph.GVizChart.prototype.setSelection = function(selection_array) {
  */
 Dygraph.GVizChart.prototype.getSelection = function() {
   var selection = [];
-  
+
   var row = this.date_graph.getSelection();
-  
+
   if (row < 0) return selection;
-  
+
   col = 1;
   for (var i in this.date_graph.layout_.datasets) {
     selection.push({row: row, column: col});