Add new issue and PR templates

[dygraphs.git] / gallery / interaction.js

diff --git a/gallery/interaction.js b/gallery/interaction.js
index 03b30e4..a903737 100644 (file)
--- a/gallery/interaction.js
+++ b/gallery/interaction.js
@@ -1,3 +1,6 @@
+/*global Gallery,Dygraph,data */
+/*global NoisyData,downV3,moveV3,upV3,clickV3,dblClickV3,scrollV3,restorePositioning,downV4,moveV4,upV4,dblClickV4,captureCanvas */
+
 Gallery.register(
   'interaction',
   {
@@ -5,47 +8,53 @@ Gallery.register(
     title: 'title',
     setup: function(parent) {
       parent.innerHTML = [
-          "<table border='1'>",
-          "<tr><td>",
-          "<b>Default interaction model</b>",
-          "<div id='div_g' style='width:600px; height:300px;'></div>",
-          "</td><td>Zoom: click-drag<br/>Pan: shift-click-drag<br/>Restore zoom level: double-click<br/>",
-          "</td></tr>",
-          "<tr><td>",
-          "<b>No interaction model</b>",
-          "<div id='div_g2' style='width:600px; height:300px;'></div>",
-          "</td><td>Click and drag all you like, it won't do anything!",
-          "<div id='g2_console'></div>",
-          "</td></tr>",
-          "<tr><td>",
-          "<b>Custom interaction model</b>",
-          "<button id='restore3'>Restore Position</button>",
-          "<div id='div_g3' style='width:600px; height:300px;'></div>",
-          "</td><td>",
-          "Zoom in: double-click, scroll wheel<br/>",
-          "Zoom out: ctrl-double-click, scroll wheel<br/>",
-          "Standard Zoom: shift-click-drag",
-          "Standard Pan: click-drag<br/>",
-          "Restore zoom level: press button<br/>",
-          "</td></tr>",
-          "<tr><td>",
-          "<b>Fun model!</b>",
-          "<div id='div_g4' style='width:600px; height:300px;'></div>",
-          "</td><td>",
-          "Keep the mouse button pressed, and hover over all points",
-          "to mark them.",
-          "</td></tr>",
-          "</table>"].join("\n");
+          "<h3>Default interaction model</h3>",
+          "<div style='width:600px;'>",
+          "  <p style='text-align:center;'>",
+          "    Zoom: click-drag, Pan: shift-click-drag, Restore: double-click",
+          "  </p>",
+          "  <div id='div_g' style='width:600px; height:300px;'></div>",
+          "</div>",
+          "",
+          "<h3>Empty interaction model</h3>",
+          "<div style='width:600px;'>",
+          "  <p style='text-align:center;'>",
+          "    Click and drag all you like, it won't do anything!",
+          "  </p>",
+          "  <div id='div_g2' style='width:600px; height:300px;'></div>",
+          "</div>",
+          "<div id='g2_console'></div>", // what is this?
+          "",
+          "<h3>Custom interaction model</h3>",
+          "<div style='width:600px;'>",
+          "  <p style='text-align:center;'>",
+          "    Zoom in: double-click, scroll wheel<br/>",
+          "    Zoom out: ctrl-double-click, scroll wheel<br/>",
+          "    Standard Zoom: shift-click-drag",
+          "    Standard Pan: click-drag<br/>",
+          "    Restore zoom level: press button<br/>",
+          "  </p>",
+          "  <button id='restore3'>Restore position</button>",
+          "  <div id='div_g3' style='width:600px; height:300px;'></div>",
+          "</div>",
+          "<h3>Fun model!</h3>",
+          "<div style='width:600px;'>",
+          "  <p style='text-align:center;'>",
+          "    Keep the mouse button pressed, and hover over all points",
+          "    to mark them.",
+          "  </p>",
+          "  <div id='div_g4' style='width:600px; height:300px;'></div>",
+          "</div>"
+          ].join('\n');
 
     },
     run: function() {
-      // TODO(konigsberg): Add cleanup to remove callbacks.
-      Dygraph.addEvent(document, "mousewheel", function() { lastClickedGraph = null; });
-      Dygraph.addEvent(document, "click", function() { lastClickedGraph = null; });
-      var g = new Dygraph(document.getElementById("div_g"),
+      var lastClickedGraph;
+      document.addEventListener("mousewheel", function() { lastClickedGraph = null; });
+      document.addEventListener("click", function() { lastClickedGraph = null; });
+      new Dygraph(document.getElementById("div_g"),
            NoisyData, { errorBars : true });
-      var s = document.getElementById("g2_console");
-      var g2 = new Dygraph(document.getElementById("div_g2"),
+      new Dygraph(document.getElementById("div_g2"),
            NoisyData,
            {
              errorBars : true,
@@ -62,15 +71,22 @@ Gallery.register(
       }});
       document.getElementById("restore3").onclick = function() {
         restorePositioning(g3);
-      }
-      var g4 = new Dygraph(document.getElementById("div_g4"),
-           NoisyData, { errorBars : true, drawPoints : true, interactionModel : {
-            'mousedown' : downV4,
-            'mousemove' : moveV4,
-            'mouseup' : upV4,
-            'dblclick' : dblClickV4,
-           },
-           underlayCallback : captureCanvas
-      });
+      };
+      new Dygraph(document.getElementById("div_g4"),
+           NoisyData, {
+             errorBars : true,
+             drawPoints : true,
+             interactionModel : {
+               'mousedown' : downV4,
+               'mousemove' : moveV4,
+               'mouseup' : upV4,
+               'dblclick' : dblClickV4
+             },
+             underlayCallback : captureCanvas
+          });
+    },
+    clean: function() {
+      document.removeEventListener('mousewheel');
+      document.removeEventListener('click');
     }
   });