* @fileoverview Tests for the updateOptions function.
* @author antrob@google.com (Anthony Robledo)
*/
-var UpdateOptionsTestCase = TestCase("update-options");
+
+import Dygraph from '../../src/dygraph';
+
+describe("update-options", function() {
+
+cleanupAfterEach();
-UpdateOptionsTestCase.prototype.opts = {
+var opts = {
width: 480,
height: 320,
};
-UpdateOptionsTestCase.prototype.data = "X,Y1,Y2\n" +
+var data = "X,Y1,Y2\n" +
"2011-01-01,2,3\n" +
"2011-02-02,5,3\n" +
"2011-03-03,6,1\n" +
"2011-04-04,9,5\n" +
"2011-05-05,8,3\n";
-UpdateOptionsTestCase.prototype.setUp = function() {
- document.body.innerHTML = "<div id='graph'></div><div id='labels'></div>";
-};
-
-UpdateOptionsTestCase.prototype.tearDown = function() {
-};
-
/*
* Tweaks the dygraph so it sets g._testDrawCalled to true when internal method
* drawGraph_ is called. Call unWrapDrawGraph when done with this.
*/
-UpdateOptionsTestCase.prototype.wrapDrawGraph = function(g) {
+var wrapDrawGraph = function(g) {
g._testDrawCalled = false;
g._oldDrawGraph = g.drawGraph_;
g.drawGraph_ = function() {
g._testDrawCalled = true;
g._oldDrawGraph.call(g);
}
-}
+};
/*
* See wrapDrawGraph
*/
-UpdateOptionsTestCase.prototype.unwrapDrawGraph = function(g) {
+var unwrapDrawGraph = function(g) {
g.drawGraph_ = g._oldDrawGraph;
}
-UpdateOptionsTestCase.prototype.testStrokeAll = function() {
+it('testStrokeAll', function() {
var graphDiv = document.getElementById("graph");
- var graph = new Dygraph(graphDiv, this.data, this.opts);
+ var graph = new Dygraph(graphDiv, data, opts);
var updatedOptions = { };
updatedOptions['strokeWidth'] = 3;
// These options will allow us to jump to renderGraph_()
// drawGraph_() will be skipped.
- this.wrapDrawGraph(graph);
+ wrapDrawGraph(graph);
graph.updateOptions(updatedOptions);
- this.unwrapDrawGraph(graph);
- assertFalse(graph._testDrawCalled);
-};
+ unwrapDrawGraph(graph);
+ assert.isFalse(graph._testDrawCalled);
+});
-UpdateOptionsTestCase.prototype.testStrokeSingleSeries = function() {
+it('testStrokeSingleSeries', function() {
var graphDiv = document.getElementById("graph");
- var graph = new Dygraph(graphDiv, this.data, this.opts);
+ var graph = new Dygraph(graphDiv, data, opts);
var updatedOptions = { };
var optionsForY1 = { };
optionsForY1['strokeWidth'] = 3;
- updatedOptions['Y1'] = optionsForY1;
+ updatedOptions['series'] = {'Y1': optionsForY1};
// These options will allow us to jump to renderGraph_()
// drawGraph_() will be skipped.
- this.wrapDrawGraph(graph);
+ wrapDrawGraph(graph);
graph.updateOptions(updatedOptions);
- this.unwrapDrawGraph(graph);
- assertFalse(graph._testDrawCalled);
-};
+ unwrapDrawGraph(graph);
+ assert.isFalse(graph._testDrawCalled);
+});
-UpdateOptionsTestCase.prototype.testSingleSeriesRequiresNewPoints = function() {
+it('testSingleSeriesRequiresNewPoints', function() {
var graphDiv = document.getElementById("graph");
- var graph = new Dygraph(graphDiv, this.data, this.opts);
- var updatedOptions = { };
- var optionsForY1 = { };
- var optionsForY2 = { };
-
- // This will not require new points.
- optionsForY1['strokeWidth'] = 2;
- updatedOptions['Y1'] = optionsForY1;
-
- // This will require new points.
- optionsForY2['stepPlot'] = true;
- updatedOptions['Y2'] = optionsForY2;
+ var graph = new Dygraph(graphDiv, data, opts);
+ var updatedOptions = {
+ series: {
+ Y1: {
+ strokeWidth: 2
+ },
+ Y2: {
+ stepPlot: true
+ }
+ }
+ };
// These options will not allow us to jump to renderGraph_()
// drawGraph_() must be called
- this.wrapDrawGraph(graph);
+ wrapDrawGraph(graph);
graph.updateOptions(updatedOptions);
- this.unwrapDrawGraph(graph);
- assertTrue(graph._testDrawCalled);
-};
+ unwrapDrawGraph(graph);
+ assert.isTrue(graph._testDrawCalled);
+});
-UpdateOptionsTestCase.prototype.testWidthChangeNeedsNewPoints = function() {
+it('testWidthChangeNeedsNewPoints', function() {
var graphDiv = document.getElementById("graph");
- var graph = new Dygraph(graphDiv, this.data, this.opts);
+ var graph = new Dygraph(graphDiv, data, opts);
var updatedOptions = { };
// This will require new points.
// These options will not allow us to jump to renderGraph_()
// drawGraph_() must be called
- this.wrapDrawGraph(graph);
+ wrapDrawGraph(graph);
graph.updateOptions(updatedOptions);
- this.unwrapDrawGraph(graph);
- assertTrue(graph._testDrawCalled);
-};
+ unwrapDrawGraph(graph);
+ assert.isTrue(graph._testDrawCalled);
+});
// Test https://github.com/danvk/dygraphs/issues/87
-UpdateOptionsTestCase.prototype.testUpdateLabelsDivDoesntInfiniteLoop = function() {
+it('testUpdateLabelsDivDoesntInfiniteLoop', function() {
var graphDiv = document.getElementById("graph");
var labelsDiv = document.getElementById("labels");
- var graph = new Dygraph(graphDiv, this.data, this.opts);
+ var graph = new Dygraph(graphDiv, data, opts);
graph.updateOptions({labelsDiv : labelsDiv});
-}
+});
// Test https://github.com/danvk/dygraphs/issues/247
-UpdateOptionsTestCase.prototype.testUpdateColors = function() {
+it('testUpdateColors', function() {
var graphDiv = document.getElementById("graph");
- var graph = new Dygraph(graphDiv, this.data, this.opts);
+ var graph = new Dygraph(graphDiv, data, opts);
var defaultColors = ["rgb(0,128,0)", "rgb(0,0,128)"];
- assertEquals(["rgb(0,128,0)", "rgb(0,0,128)"], graph.getColors());
+ assert.deepEqual(["rgb(0,128,0)", "rgb(0,0,128)"], graph.getColors());
var colors1 = [ "#aaa", "#bbb" ];
graph.updateOptions({ colors: colors1 });
- assertEquals(colors1, graph.getColors());
+ assert.deepEqual(colors1, graph.getColors());
// extra colors are ignored until you add additional data series.
var colors2 = [ "#ddd", "#eee", "#fff" ];
graph.updateOptions({ colors: colors2 });
- assertEquals(["#ddd", "#eee"], graph.getColors());
+ assert.deepEqual(["#ddd", "#eee"], graph.getColors());
graph.updateOptions({ file:
"X,Y1,Y2,Y3\n" +
"2011-01-01,2,3,4\n" +
"2011-02-02,5,3,2\n"
});
- assertEquals(colors2, graph.getColors());
+ assert.deepEqual(colors2, graph.getColors());
- graph.updateOptions({ colors: null, file: this.data });
- assertEquals(defaultColors, graph.getColors());
-}
+ graph.updateOptions({ colors: null, file: data });
+ assert.deepEqual(defaultColors, graph.getColors());
+});
+
+// Regression test for http://code.google.com/p/dygraphs/issues/detail?id=249
+// Verifies that setting 'legend: always' via update immediately shows the
+// legend.
+it('testUpdateLegendAlways', function() {
+ var graphDiv = document.getElementById("graph");
+ var graph = new Dygraph(graphDiv, data, opts);
+
+ var legend = document.getElementsByClassName("dygraph-legend");
+ assert.equal(1, legend.length);
+ legend = legend[0];
+ assert.equal("", legend.innerHTML);
+
+ graph.updateOptions({legend: 'always'});
+
+ legend = document.getElementsByClassName("dygraph-legend");
+ assert.equal(1, legend.length);
+ legend = legend[0];
+ assert.notEqual(-1, legend.textContent.indexOf("Y1"));
+ assert.notEqual(-1, legend.textContent.indexOf("Y2"));
+});
+
+});
projects / dygraphs.git / blobdiff