projects
/
dygraphs.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
add auto_test from Issue 242
[dygraphs.git]
/
dygraph.js
diff --git
a/dygraph.js
b/dygraph.js
index
cec7c20
..
a0e55ab
100644
(file)
--- a/
dygraph.js
+++ b/
dygraph.js
@@
-408,6
+408,12
@@
Dygraph.prototype.__init__ = function(div, file, attrs) {
// TODO(nikhilk): Add any other stackedGraph checks here.
}
// TODO(nikhilk): Add any other stackedGraph checks here.
}
+ // These two options have a bad interaction. See issue 359.
+ if (attrs.showRangeSelector && attrs.animatedZooms) {
+ this.warn('You should not set animatedZooms=true when using the range selector.');
+ attrs.animatedZooms = false;
+ }
+
// Dygraphs has many options, some of which interact with one another.
// To keep track of everything, we maintain two sets of options:
//
// Dygraphs has many options, some of which interact with one another.
// To keep track of everything, we maintain two sets of options:
//
@@
-437,8
+443,8
@@
Dygraph.prototype.__init__ = function(div, file, attrs) {
// Activate plugins.
this.plugins_ = [];
for (var i = 0; i < Dygraph.PLUGINS.length; i++) {
// Activate plugins.
this.plugins_ = [];
for (var i = 0; i < Dygraph.PLUGINS.length; i++) {
- var
p
lugin = Dygraph.PLUGINS[i];
- var pluginInstance = new
p
lugin();
+ var
P
lugin = Dygraph.PLUGINS[i];
+ var pluginInstance = new
P
lugin();
var pluginDict = {
plugin: pluginInstance,
events: {},
var pluginDict = {
plugin: pluginInstance,
events: {},
@@
-482,7
+488,7
@@
Dygraph.prototype.__init__ = function(div, file, attrs) {
* @private
*/
Dygraph.prototype.cascadeEvents_ = function(name, extra_props) {
* @private
*/
Dygraph.prototype.cascadeEvents_ = function(name, extra_props) {
- if (!
name in this.eventListeners_
) return true;
+ if (!
(name in this.eventListeners_)
) return true;
// QUESTION: can we use objects & prototypes to speed this up?
var e = {
// QUESTION: can we use objects & prototypes to speed this up?
var e = {
@@
-518,11
+524,13
@@
Dygraph.prototype.cascadeEvents_ = function(name, extra_props) {
* Axis is an optional parameter. Can be set to 'x' or 'y'.
*
* The zoomed status for an axis is set whenever a user zooms using the mouse
* Axis is an optional parameter. Can be set to 'x' or 'y'.
*
* The zoomed status for an axis is set whenever a user zooms using the mouse
- * or when the dateWindow or valueRange are updated (unless the
isZoomedIgnoreProgrammaticZoom
- * option is also specified).
+ * or when the dateWindow or valueRange are updated (unless the
+ *
isZoomedIgnoreProgrammaticZoom
option is also specified).
*/
Dygraph.prototype.isZoomed = function(axis) {
*/
Dygraph.prototype.isZoomed = function(axis) {
- if (axis == null) return this.zoomed_x_ || this.zoomed_y_;
+ if (axis === null || axis === undefined) {
+ return this.zoomed_x_ || this.zoomed_y_;
+ }
if (axis === 'x') return this.zoomed_x_;
if (axis === 'y') return this.zoomed_y_;
throw "axis parameter is [" + axis + "] must be null, 'x' or 'y'.";
if (axis === 'x') return this.zoomed_x_;
if (axis === 'y') return this.zoomed_y_;
throw "axis parameter is [" + axis + "] must be null, 'x' or 'y'.";
@@
-570,7
+578,7
@@
Dygraph.prototype.attr_ = function(name, seriesName) {
}
if (seriesName === this.highlightSet_ &&
this.user_attrs_.hasOwnProperty('highlightSeriesOpts')) {
}
if (seriesName === this.highlightSet_ &&
this.user_attrs_.hasOwnProperty('highlightSeriesOpts')) {
- sources.push(this.user_attrs_
['highlightSeriesOpts']
);
+ sources.push(this.user_attrs_
.highlightSeriesOpts
);
}
}
}
}
}
}
@@
-1245,6
+1253,10
@@
Dygraph.prototype.createDragInterface_ = function() {
boundedDates: null, // [minDate, maxDate]
boundedValues: null, // [[minValue, maxValue] ...]
boundedDates: null, // [minDate, maxDate]
boundedValues: null, // [[minValue, maxValue] ...]
+ // We cover iframes during mouse interactions. See comments in
+ // dygraph-utils.js for more info on why this is a good idea.
+ tarp: new Dygraph.IFrameTarp(),
+
// contextB is the same thing as this context object but renamed.
initializeMouseDown: function(event, g, contextB) {
// prevents mouse drags from selecting page text.
// contextB is the same thing as this context object but renamed.
initializeMouseDown: function(event, g, contextB) {
// prevents mouse drags from selecting page text.
@@
-1260,6
+1272,7
@@
Dygraph.prototype.createDragInterface_ = function() {
contextB.dragStartX = g.dragGetX_(event, contextB);
contextB.dragStartY = g.dragGetY_(event, contextB);
contextB.cancelNextDblclick = false;
contextB.dragStartX = g.dragGetX_(event, contextB);
contextB.dragStartY = g.dragGetY_(event, contextB);
contextB.cancelNextDblclick = false;
+ contextB.tarp.cover();
}
};
}
};
@@
-1299,6
+1312,8
@@
Dygraph.prototype.createDragInterface_ = function() {
delete self.axes_[i].dragValueRange;
}
}
delete self.axes_[i].dragValueRange;
}
}
+
+ context.tarp.uncover();
};
this.addEvent(document, 'mouseup', this.mouseUpHandler_);
};
this.addEvent(document, 'mouseup', this.mouseUpHandler_);
@@
-1521,7
+1536,8
@@
Dygraph.prototype.doUnzoom_ = function() {
newValueRanges = [];
for (i = 0; i < this.axes_.length; i++) {
var axis = this.axes_[i];
newValueRanges = [];
for (i = 0; i < this.axes_.length; i++) {
var axis = this.axes_[i];
- newValueRanges.push(axis.valueRange != null ? axis.valueRange : axis.extremeRange);
+ newValueRanges.push(axis.valueRange !== null ?
+ axis.valueRange : axis.extremeRange);
}
}
}
}
@@
-1723,7
+1739,7
@@
Dygraph.prototype.findStackedPoint = function(domX, domY) {
}
}
// Stop if the point (domX, py) is above this series' upper edge
}
}
// Stop if the point (domX, py) is above this series' upper edge
- if (setIdx == 0 || py < domY) {
+ if (setIdx ==
=
0 || py < domY) {
closestPoint = p1;
closestSeries = setIdx;
}
closestPoint = p1;
closestSeries = setIdx;
}
@@
-1952,7
+1968,7
@@
Dygraph.prototype.setSelection = function(row, opt_seriesName, opt_locked) {
point = this.layout_.unstackPointAtIndex(setIdx, row);
}
point = this.layout_.unstackPointAtIndex(setIdx, row);
}
- if (
!(point.yval === null)
) this.selPoints_.push(point);
+ if (
point.yval !== null
) this.selPoints_.push(point);
}
}
} else {
}
}
} else {
@@
-2096,7
+2112,7
@@
Dygraph.prototype.extremeValues_ = function(series) {
// With custom bars, maxY is the max of the high values.
for (j = 0; j < series.length; j++) {
y = series[j][1][0];
// With custom bars, maxY is the max of the high values.
for (j = 0; j < series.length; j++) {
y = series[j][1][0];
- if (
!y
) continue;
+ if (
y === null || isNaN(y)
) continue;
var low = y - series[j][1][1];
var high = y + series[j][1][2];
if (low > y) low = y; // this can happen with custom bars,
var low = y - series[j][1][1];
var high = y + series[j][1][2];
if (low > y) low = y; // this can happen with custom bars,
@@
-3134,7
+3150,7
@@
Dygraph.prototype.parseDataTable_ = function(data) {
num = Math.floor((num - 1) / 26);
}
return shortText;
num = Math.floor((num - 1) / 26);
}
return shortText;
- }
+ }
;
var cols = data.getNumberOfColumns();
var rows = data.getNumberOfRows();
var cols = data.getNumberOfColumns();
var rows = data.getNumberOfRows();